Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Labels:None
-
Story Points:8
-
Epic Link:
-
Sprint:AP S22-6 (May)
-
Team:Alert Production
-
Urgent?:No
Description
Currently, ApPipe.yaml is considered the "base" AP pipeline; it is included by ApVerify.yaml, which is in turn included by ApVerifyWithFakes.yaml. However, this design causes problems for ApVerifyWithFakes, which has a significantly different structure (in particular, a distinction between steps done with and without fakes) and its own rules for which metrics instrument which tasks.
The problem can be mitigated by splitting ApPipe.yaml into two pipelines: one which is a dependency of ApVerify.yaml, and a new ApPipeWithFakes.yaml that is a dependency of ApVerifyWithFakes.yaml. ApPipe.yaml and ApPipeWithFakes.yaml will not depend on each other, allowing each to have the labels, contracts, and other elements that are appropriate for that pipeline.
Configurations that should be shared between the two pipelines should be factored out into their own configs, consistent with RFC-775 guidelines.
Attachments
Issue Links
Activity
Krzysztof Findeisen
created issue -
Krzysztof Findeisen
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Description |
Currently, {{ApPipe.yaml}} is considered the "base" AP pipeline; it is included by {{ApVerify.yaml}}, which is in turn included by {{ApVerifyWithFakes.yaml}}. However, this design causes problems for {{ApVerifyWithFakes}}, which has a significantly different structure (in particular, a distinction between steps done with and without fakes) and its own rules for which metrics instrument which tasks.
The problem can be mitigated by splitting {{ApPipe.yaml}} into two pipelines: one which is a dependency of {{ApVerify.yaml}}, and a new {{ApPipeWithFakes.yaml}} that is a dependency of {{ApVerifyWithFakes.yaml}}. {{ApPipe.yaml}} and {{ApPipeWithFakes.yaml}} will not depend on each other, allowing each to have the labels, contracts, and other elements that are appropriate for that pipeline. |
Currently, {{ApPipe.yaml}} is considered the "base" AP pipeline; it is included by {{ApVerify.yaml}}, which is in turn included by {{ApVerifyWithFakes.yaml}}. However, this design causes problems for {{ApVerifyWithFakes}}, which has a significantly different structure (in particular, a distinction between steps done with and without fakes) and its own rules for which metrics instrument which tasks.
The problem can be mitigated by splitting {{ApPipe.yaml}} into two pipelines: one which is a dependency of {{ApVerify.yaml}}, and a new {{ApPipeWithFakes.yaml}} that is a dependency of {{ApVerifyWithFakes.yaml}}. {{ApPipe.yaml}} and {{ApPipeWithFakes.yaml}} will not depend on each other, allowing each to have the labels, contracts, and other elements that are appropriate for that pipeline. Configurations that should be shared between the two pipelines should be factored out into their own configs, consistent with RFC-775 guidelines. |
Krzysztof Findeisen
made changes -
| Rank | Ranked higher |
Krzysztof Findeisen
made changes -
Krzysztof Findeisen
made changes -
| Rank | Ranked higher |
| Sprint | AP S22-4 (March) [ 1148 ] |
| Rank | Ranked higher |
| Sprint | AP S22-4 (March) [ 1148 ] | AP S22-5 (April) [ 1156 ] |
| Rank | Ranked lower |
Krzysztof Findeisen
made changes -
| Rank | Ranked higher |
Krzysztof Findeisen
made changes -
| Sprint | AP S22-5 (April) [ 1156 ] | AP S22-6 (May) [ 1161 ] |
Krzysztof Findeisen
made changes -
| Rank | Ranked higher |
Krzysztof Findeisen
made changes -
| Sprint | AP S22-6 (May) [ 1161 ] | AP S22-5 (April) [ 1156 ] |
Krzysztof Findeisen
made changes -
| Rank | Ranked lower |
Krzysztof Findeisen
made changes -
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Story Points | 4 | 8 |
| Sprint | AP S22-5 (April) [ 1156 ] | AP S22-6 (May) [ 1161 ] |
| Rank | Ranked higher |
Krzysztof Findeisen
made changes -
Krzysztof Findeisen
made changes -
| Reviewers | Meredith Rawls [ mrawls ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
Krzysztof Findeisen
made changes -
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Krzysztof Findeisen
made changes -