Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32714

Fix backwards compatibility broken by DM-32649

    XMLWordPrintable

    Details

      Description

      DM-32649 broke backwards compatibility, in that it makes it not possible to run the psf quality selection task (as is done in hsc runs) with calexps generated with weeklies prior to that ticket.

      This ticket will restore backwards compatibility by adding a configuration parameter that can be set for backwards compatibility mode.

        Attachments

          Issue Links

            Activity

            Hide
            kannawad Arun Kannawadi added a comment - - edited

            Good to go pending backport-approved label and Jenkins running succesfully.

            Show
            kannawad Arun Kannawadi added a comment - - edited Good to go pending backport-approved label and Jenkins running succesfully.
            Hide
            erykoff Eli Rykoff added a comment - - edited

            I've added a helpful backwards compatibility message since the review. Running the following code:

            pipetask run -b /repo/main \
            -i HSC/runs/RC2/w_2021_42/DM-32248 \
            -o u/erykoff/RC2/w42/makeWarp \
            -d "" --register-dataset-types \
            -p  $OBS_SUBARU_DIR/pipelines/DRP.yaml#makeWarp \
            -d "tract=9697 AND band='i' AND patch=23 AND skymap='hsc_rings_v1'"
            

            Gives the following error:

            RuntimeError: Old calexps detected. Please set config.doLegacyStarSelectionComputation=True for backwards compatibility.
            

            Then rerunning

            pipetask run -b /repo/main \
            -i HSC/runs/RC2/w_2021_42/DM-32248 \
            -o u/erykoff/RC2/w42/makeWarp \
            -d "" --register-dataset-types \
            -p  $OBS_SUBARU_DIR/pipelines/DRP.yaml#makeWarp \
            -d "tract=9697 AND band='i' AND patch=23 AND skymap='hsc_rings_v1'" \
            -c makeWarp:select.doLegacyStarSelectionComputation=True
            

            runs as it is supposed to.

            Show
            erykoff Eli Rykoff added a comment - - edited I've added a helpful backwards compatibility message since the review. Running the following code: pipetask run -b /repo/main \ -i HSC /runs/RC2/w_2021_42/DM-32248 \ -o u /erykoff/RC2/w42/makeWarp \ -d "" --register-dataset-types \ -p $OBS_SUBARU_DIR /pipelines/DRP .yaml #makeWarp \ -d "tract=9697 AND band='i' AND patch=23 AND skymap='hsc_rings_v1'" Gives the following error: RuntimeError: Old calexps detected. Please set config.doLegacyStarSelectionComputation=True for backwards compatibility. Then rerunning pipetask run -b /repo/main \ -i HSC /runs/RC2/w_2021_42/DM-32248 \ -o u /erykoff/RC2/w42/makeWarp \ -d "" --register-dataset-types \ -p $OBS_SUBARU_DIR /pipelines/DRP .yaml #makeWarp \ -d "tract=9697 AND band='i' AND patch=23 AND skymap='hsc_rings_v1'" \ -c makeWarp: select .doLegacyStarSelectionComputation=True runs as it is supposed to.
            Hide
            kannawad Arun Kannawadi added a comment -

            Thank you Eli! I think that's a sensible thing to do.

            Show
            kannawad Arun Kannawadi added a comment - Thank you Eli! I think that's a sensible thing to do.
            Hide
            erykoff Eli Rykoff added a comment -

            For the backport jenkins run here https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35494/pipeline/46 the macos passed and the linux passed ci_hsc_gen3 (most important), and then had some sort of jenkins hiccup at the very end. So I'm just going to hit the green merge button.

            Show
            erykoff Eli Rykoff added a comment - For the backport jenkins run here https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35494/pipeline/46 the macos passed and the linux passed ci_hsc_gen3 (most important), and then had some sort of jenkins hiccup at the very end. So I'm just going to hit the green merge button.

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Arun Kannawadi
              Watchers:
              Arun Kannawadi, Colin Slater, Eli Rykoff, Hsin-Fang Chiang, Lauren MacArthur, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.