Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32733

Config.loadFromStream doesn't actually accept a file-like object

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pex_config
    • Labels:
      None

      Description

      Config.loadFromStream is documented as accepting a file-like object, but it actually requires a string, bytes, or code object, because the result is passed directly to exec. It is apparently only called by Config.load, which does pass it a code object.

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. DM-9601 Config.loadFromStream does not accept StringIO objects (and maybe files)

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32759 Drop already-deprecated support for "root" in config files

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Fred Moolekamp, sending you this just to help you catch up on Yusra's ticket-review leaderboard. It's a pretty straightforward fix of a pretty straightforward bug.

            PR is https://github.com/lsst/pex_config/pull/63

            Show
            jbosch Jim Bosch added a comment - Fred Moolekamp , sending you this just to help you catch up on Yusra's ticket-review leaderboard. It's a pretty straightforward fix of a pretty straightforward bug. PR is https://github.com/lsst/pex_config/pull/63
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Sure, no problem!

            Show
            fred3m Fred Moolekamp added a comment - Sure, no problem!
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Looks good. A few comments in the PR about a deprecated parameter.

            I think this ticket also solves DM-9601.

            Show
            fred3m Fred Moolekamp added a comment - Looks good. A few comments in the PR about a deprecated parameter. I think this ticket also solves DM-9601 .

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Jim Bosch
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.