Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32759

Drop already-deprecated support for "root" in config files

    XMLWordPrintable

    Details

    • Story Points:
      0.25
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The special symbol used as the base of the configuration tree in pex_config files was changed from "root" to "config" on RFC-62 and DM-3630, before we had a deprecation policy; support for reading files with "root" was left in but deprecated indefinitely. It's now been 6 years, and we should probably remove support for "root".

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-32733 Config.loadFromStream doesn't actually accept a file-like object

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-3630 Change root to config in config override files

          • Done

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-62 Make config files and command line specifications of configurations consistent

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Link This issue relates to RFC-62 [ RFC-62 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-3630 [ DM-3630 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-32733 [ DM-32733 ]
            tjenness Tim Jenness made changes -
            Team Architecture [ 10304 ]
            tjenness Tim Jenness made changes -
            Assignee Tim Jenness [ tjenness ]
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I did this because it seemed to be only 5 minutes work.

            Show
            tjenness Tim Jenness added a comment - I did this because it seemed to be only 5 minutes work.
            tjenness Tim Jenness made changes -
            Reviewers Jim Bosch [ jbosch ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Story Points 0.25
            tjenness Tim Jenness made changes -
            Labels gen3-middleware
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Looks good. Wish we'd had the foresight to immediately deprecate the "root" argument, too, and force every config to use "config" always, but that's not what we wrote in the docs, so I think this is all we can do (and it's not a big deal anyway).

            Show
            jbosch Jim Bosch added a comment - Looks good. Wish we'd had the foresight to immediately deprecate the "root" argument, too, and force every config to use "config" always, but that's not what we wrote in the docs, so I think this is all we can do (and it's not a big deal anyway).
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.