Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32831

add a butler remove-runs CLI command

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Epic Link:
    • Sprint:
      DB_S22_12
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      Add the remove-runs command, per comments in DM-32500.

      Reword the remove-collections command output (add language about how to remove runs), per this slack discussion: https://lsstc.slack.com/archives/C01FBUGM2CV/p1638222714262300?thread_ts=1638218403.251700&cid=C01FBUGM2CV

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-33619 Add unlink option to butler remove-runs

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-32499 deprecate butler prune-collections

          • Done

          Bug - A problem which impairs or prevents the functions of the product. DM-32500 Attempting to remove a chain with --purge gives confusing behavior

          • Won't Fix

          Bug - A problem which impairs or prevents the functions of the product. DM-32501 Calibration collections cannot be removed

          • Won't Fix

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32687 add a butler remove-collections command

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            npease Nate Pease [X] (Inactive) added a comment - - edited

            asked on Slack #dm-middleware-support about having a confirmation dialog, seems like the safe thing to do is keep it, and have it confirm by default. K-T suggested an output template that should be more terse:

            The following RUN collections will be removed:
            ingest/run, ingest/run2, ingest/run3, ingest/run-do-not-delete

            The following datasets will be removed:
            test_metric_comp(2), raw(102304), calexp(102303), ic_src(40204)

            Show
            npease Nate Pease [X] (Inactive) added a comment - - edited asked on Slack #dm-middleware-support about having a confirmation dialog, seems like the safe thing to do is keep it, and have it confirm by default. K-T suggested an output template that should be more terse: The following RUN collections will be removed: ingest/run, ingest/run2, ingest/run3, ingest/run-do-not-delete The following datasets will be removed: test_metric_comp(2), raw(102304), calexp(102303), ic_src(40204)
            Hide
            Permalink
            npease Nate Pease [X] (Inactive) added a comment - - edited

            Tim, can you review? No rush on my end, could wait until January even I think. (it might be good to get the mypy pin in though?)

            Show
            npease Nate Pease [X] (Inactive) added a comment - - edited Tim, can you review? No rush on my end, could wait until January even I think. (it might be good to get the mypy pin in though?)
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks okay. Some minor fixups requested on the PR and also a comment that I'm not sure why we are special-casing the butler repo not being found for this specific command but no others.

            Show
            tjenness Tim Jenness added a comment - Looks okay. Some minor fixups requested on the PR and also a comment that I'm not sure why we are special-casing the butler repo not being found for this specific command but no others.

              People

              Assignee:
              npease Nate Pease [X] (Inactive)
              Reporter:
              npease Nate Pease [X] (Inactive)
              Reviewers:
              Tim Jenness
              Watchers:
              Nate Pease [X] (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.