Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_middleware
-
Labels:
-
Story Points:0
-
Team:Telescope and Site
-
Urgent?:No
Description
Fix two minor issues with ts_sal SALPY tests:
- The timeout argument in get_topic is ignored
- ScriptTestCase refers to Generics instead of AddedGenerics. Also test for the enable command instead of enterControl, to make the test stronger.
Unfortunately these changes are difficult to test due to DM-32954.
Note that SALPY unit tests will continue to be required until we have C++ unit tests and the Java tests are implemented (DM-32442) and beefed up (DM-32914 and DM-32952).
Attachments
Issue Links
- is triggered by
-
DM-32954 SALPY is broken for me.
- Invalid
Dave Mills In addition to reviewing the PR can you please run the unit tests locally? I cannot due to
DM-32954.Pull request: https://github.com/lsst-ts/ts_sal/pull/168