Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32956

Update SALPY unit tests

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:
    • Story Points:
      0
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Fix two minor issues with ts_sal SALPY tests:

      • The timeout argument in get_topic is ignored
      • ScriptTestCase refers to Generics instead of AddedGenerics. Also test for the enable command instead of enterControl, to make the test stronger.

      Unfortunately these changes are difficult to test due to DM-32954.

      Note that SALPY unit tests will continue to be required until we have C++ unit tests and the Java tests are implemented (DM-32442) and beefed up (DM-32914 and DM-32952).

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32954 SALPY is broken for me.

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Dave Mills In addition to reviewing the PR can you please run the unit tests locally? I cannot due to DM-32954.

            Pull request: https://github.com/lsst-ts/ts_sal/pull/168

            Show
            rowen Russell Owen added a comment - - edited Dave Mills In addition to reviewing the PR can you please run the unit tests locally? I cannot due to DM-32954 . Pull request: https://github.com/lsst-ts/ts_sal/pull/168
            Hide
            Permalink
            dmills Dave Mills added a comment -

            ok

            Show
            dmills Dave Mills added a comment - ok
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Dave kindly merged this after testing it on his own system.

            Show
            rowen Russell Owen added a comment - Dave kindly merged this after testing it on his own system.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Dave Mills
              Watchers:
              Dave Mills, Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.