Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-32995

Update salobj to publish errorCode=0 when going out of fault

    XMLWordPrintable

    Details

      Description

      Update salobj BaseCsc to publish the errorCode event with errorCode=0, report="", etc. when going out of fault state.

      Also update the fault method to publish a CRITICAL-level message with the error code and report. This trivial change should allow LOVE to simplify the unified log window to get rid of the error code event data. Something like:

      self.log.critical(f"Fault! errorCode=\{code\}, reason=\{reason!r\}")
      

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -
            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/217
            Hide
            rowen Russell Owen added a comment -

            Reviewed on github.

            Show
            rowen Russell Owen added a comment - Reviewed on github.
            Hide
            rowen Russell Owen added a comment - - edited

            Merged to develop. I will tag the release as part of DM-33031.

            Show
            rowen Russell Owen added a comment - - edited Merged to develop. I will tag the release as part of DM-33031 .

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Rob Bovill
              Watchers:
              Rob Bovill, Russell Owen, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.