Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33062

Update the Sync Pattern in Hexapod CSC

    XMLWordPrintable

    Details

      Description

      Please help to update the sync pattern in hexapod CSC to use the value of 0x5555 for the controller to use. The hexapod controller will only do the command acknowledgement when the input command has this 0x5555 value. This will align the behavior between the hexapod and rotator CSCs.

      The existed values now are:
      1. 0xB4B4
      2. 0x6666

      The CSC code is here:
      https://github.com/lsst-ts/ts_mthexapod/blob/develop/python/lsst/ts/mthexapod/constants.py#L79-L89 

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31232 Acknowledge the SAL Command from Hexapod PXI

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33057 Release RO's packages that require ts_xml 10.2

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Thank you for using the same value for both hexapods and the rotator. That allows a future simplification: change ts_hexrotcomm to have the sync pattern and get rid of it from ts_mtrotator and ts_mthexapod. However, for now I am keeping the flexibility of 3 different sync patterns, in case you decide to go back. So I just replaced the two old sync patterns with the new one in ts_mthexapod.

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Thank you for using the same value for both hexapods and the rotator. That allows a future simplification: change ts_hexrotcomm to have the sync pattern and get rid of it from ts_mtrotator and ts_mthexapod. However, for now I am keeping the flexibility of 3 different sync patterns, in case you decide to go back. So I just replaced the two old sync patterns with the new one in ts_mthexapod. Pull requests: https://github.com/lsst-ts/ts_mthexapod/pull/60 (0.22 release branch) https://github.com/lsst-ts/ts_mthexapod/pull/61 (develop branch)
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            Reviewed in GitHub. It looks like there is some problems for the Jenkins test because of the version problem. But I think we are good to merge the code. Thanks!

            Please help to add the story point in this ticket. Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - - edited Reviewed in GitHub. It looks like there is some problems for the Jenkins test because of the version problem. But I think we are good to merge the code. Thanks! Please help to add the story point in this ticket. Thanks!
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Tagged ts_mthexapod v0.22.1

            Show
            rowen Russell Owen added a comment - Tagged ts_mthexapod v0.22.1

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Te-Wei Tsai
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.