Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33073

Update Eigen to 3.3.9

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • eigen
    • None

    Description

      Eigen 3.3.7 does not compile with c++20 enabled and the eups stack patched version does not match the conda stack version 3.3.9.

      This problem is fixed in Eigen 3.3.9.  https://gitlab.com/libeigen/eigen/-/issues/2012

      For 3.3.7 a one line back port could be applied as patch:
      https://gitlab.com/libeigen/eigen/-/commit/7a0a2a50019c5a8593497b90ffbfadf8db2c874b 

      Attachments

        Issue Links

          Activity

            wittgen Matthias Wittgen added a comment - - edited

            Upgrading the eigen to 3.3.9 should be a better fix. This would be consistent with the version installed from rubin-env.
            https://github.com/lsst/eigen/tree/u/wittgen/eigen339 passes CI.
            The original trigger for this was to try out enabling C++20 in gcc11 for lsst_distrib, which compiles with minimal code changes.

            wittgen Matthias Wittgen added a comment - - edited Upgrading the eigen to 3.3.9 should be a better fix. This would be consistent with the version installed from rubin-env. https://github.com/lsst/eigen/tree/u/wittgen/eigen339  passes CI. The original trigger for this was to try out enabling C++20 in gcc11 for lsst_distrib, which compiles with minimal code changes.
            tjenness Tim Jenness added a comment -

            I see that eigen 3.4.0 is on conda-forge. Can we update the eups package to 3.3.9?

            It looks like using 3.4.0 is currently blocked by DM-32456.

            tjenness Tim Jenness added a comment - I see that eigen 3.4.0 is on conda-forge. Can we update the eups package to 3.3.9? It looks like using 3.4.0 is currently blocked by DM-32456 .

            Updating to 3.3.9 would put the current conda version in sync with the patched eups stack version.

            wittgen Matthias Wittgen added a comment - Updating to 3.3.9 would put the current conda version in sync with the patched eups stack version.
            wittgen Matthias Wittgen added a comment - Passes CI pipeline: https://ci.lsst.codes/job/stack-os-matrix/36358/display/redirect
            ktl Kian-Tat Lim added a comment -

            While this is a usable workaround, I would much rather solve the problem by fixing DM-32456 and then dropping eups eigen altogether.

            Nevertheless,this appears to be a useful update.

             

            ktl Kian-Tat Lim added a comment - While this is a usable workaround, I would much rather solve the problem by fixing DM-32456 and then dropping eups eigen altogether. Nevertheless,this appears to be a useful update.  

            People

              wittgen Matthias Wittgen
              wittgen Matthias Wittgen
              Kian-Tat Lim, Tim Jenness
              Kian-Tat Lim, Matthias Wittgen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.