Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: eigen
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Team:Architecture
-
Urgent?:No
Description
Eigen 3.3.7 does not compile with c++20 enabled and the eups stack patched version does not match the conda stack version 3.3.9.
This problem is fixed in Eigen 3.3.9. https://gitlab.com/libeigen/eigen/-/issues/2012
For 3.3.7 a one line back port could be applied as patch:
https://gitlab.com/libeigen/eigen/-/commit/7a0a2a50019c5a8593497b90ffbfadf8db2c874b
Attachments
Issue Links
- relates to
-
- Done
Activity
I see that eigen 3.4.0 is on conda-forge. Can we update the eups package to 3.3.9?
It looks like using 3.4.0 is currently blocked by DM-32456.
Updating to 3.3.9 would put the current conda version in sync with the patched eups stack version.
Matthias Wittgen
added a comment - Updating to 3.3.9 would put the current conda version in sync with the patched eups stack version. Passes CI pipeline:
https://ci.lsst.codes/job/stack-os-matrix/36358/display/redirect
Matthias Wittgen
added a comment - Passes CI pipeline:
https://ci.lsst.codes/job/stack-os-matrix/36358/display/redirect While this is a usable workaround, I would much rather solve the problem by fixing DM-32456 and then dropping eups eigen altogether.
Nevertheless,this appears to be a useful update.
Upgrading the eigen to 3.3.9 should be a better fix. This would be consistent with the version installed from rubin-env.
https://github.com/lsst/eigen/tree/u/wittgen/eigen339 passes CI.
The original trigger for this was to try out enabling C++20 in gcc11 for lsst_distrib, which compiles with minimal code changes.