Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
During construction of the DRP.yaml data processing pipeline for DECam data, the config over-ride doCrosstalk: false was erroneously left out of the isrForCrosstalkSources task. This ticket adds it back in.
For reference, see the reference task in AP at: https://github.com/lsst/ap_pipe/blob/main/pipelines/DarkEnergyCamera/RunIsrForCrosstalkSources.yaml
Attachments
Issue Links
- relates to
-
DM-32430 Create DECam DRP Processing Pipeline
- Done
Activity
I am not particularly concerned about Jenkins for a one-line config change, but thank you for being thorough!
Per discussion on Slack, maybe sometime we should list more tasks we want to ensure stay off for the "isrForCrosstalkSources" task in both AP and DRP pipelines, but for now I am pretty confident this one-line change will have the desired behavior.
Thanks Meredith, much appreciated. For reference, here are all the current boolean do flags in the isrForCrosstalkSources task (including this ticket):
config.doConvertIntToFloat=True
|
config.doSaturation=True
|
config.doSuspect=True
|
config.doSetBadRegions=True
|
config.doOverscan=True
|
config.doAssembleCcd=False
|
config.doAssembleIsrExposures=False
|
config.doTrimToMatchCalib=True
|
config.doBias=False
|
config.doBiasBeforeOverscan=False
|
config.doVariance=False
|
config.doEmpiricalReadNoise=False
|
config.doLinearize=False
|
config.doCrosstalk=False
|
config.doCrosstalkBeforeAssemble=True
|
config.doDefect=False
|
config.doNanMasking=False
|
config.doWidenSaturationTrails=True
|
config.doBrighterFatter=False
|
config.doDark=False
|
config.doStrayLight=False
|
config.doFlat=False
|
config.doTweakFlat=False
|
config.doApplyGains=False
|
config.doFringe=False
|
config.doAmpOffset=False
|
config.doMeasureBackground=True
|
config.doCameraSpecificMasking=False
|
config.doInterpolate=False
|
config.doSaturationInterpolation=True
|
config.doNanInterpolation=True
|
config.doNanInterpAfterFlat=False
|
config.doSaveInterpPixels=False
|
config.doVignette=False
|
config.doMaskVignettePolygon=True
|
config.doAttachTransmissionCurve=False
|
config.doUseOpticsTransmission=False
|
config.doUseFilterTransmission=False
|
config.doUseSensorTransmission=False
|
config.doUseAtmosphereTransmission=False
|
config.doIlluminationCorrection=False
|
config.doWrite=True
|
I agree, it would be good to look at these again to see which we want to leave as-is, and which we want to update.
Thanks again Meredith. Ticket merged, and branch deleted!
Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/35646/pipeline