Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33150

Remove Gen 2 support from ap_verify

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:

      Description

      Remove all Gen 2 support from ap_verify. This includes:

      • Running ap_verify_dataset_template/scripts/add_gen3_repo.py --drop-gen2 on each dataset repository, then deleting the script and all convertRepo_*.py configs.
      • Updating all documentation of the ap_verify dataset format to be Gen 3 only.
      • Removing the --gen2 and --gen3 command-line flags from the ap_verify scripts.
      • Removing the Gen 2 ingest and pipeline execution code.
      • Removing the metrics.py module entirely (including its command-line flags).
      • Removing the Gen 2 metrics config files config/default_*_metrics.py.
      • Reviewing the documentation to ensure there is no remaining Gen 2 content.
      • Removing Gen 2 runs from Jenkins and alerts from SQuaSH.
      • Removing Gen 2 display from SQuaSH.

      This ticket does not cover removing Gen 2 support from the lsst.verify.MetricTask framework, as that might still be in use by other parties.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Eric Bellm, Ian Sullivan, I just realized we never actually ticketed this work. Any objections to scheduling it for January? Note that this would include removing the "Gen 2 vs. Gen 3" display from SQuaSH.

            Show
            krzys Krzysztof Findeisen added a comment - Eric Bellm , Ian Sullivan , I just realized we never actually ticketed this work. Any objections to scheduling it for January? Note that this would include removing the "Gen 2 vs. Gen 3" display from SQuaSH.
            Hide
            sullivan Ian Sullivan added a comment -

            This looks great! Please go ahead and take care of this in January.

            Show
            sullivan Ian Sullivan added a comment - This looks great! Please go ahead and take care of this in January.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Thanks for agreeing to review this, John Parejko. Changes to code packages should be self-explanatory; those to ap_verify may be easier to review one commit at a time. For datasets, I think only the readme, docs, and configs are worth reviewing; I recommend skipping the "Create standalone Gen 3 repo." commit entirely.

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for agreeing to review this, John Parejko . Changes to code packages should be self-explanatory; those to ap_verify may be easier to review one commit at a time. For datasets, I think only the readme, docs, and configs are worth reviewing; I recommend skipping the "Create standalone Gen 3 repo." commit entirely.
            Hide
            Parejkoj John Parejko added a comment -

            Comments on the PRs, otherwise this looks good. Thanks for keeping all the docs up to date!

            I didn't look at the data changes in the datasets packages, and the handful of docs/config changes in them were all fine.

            Show
            Parejkoj John Parejko added a comment - Comments on the PRs, otherwise this looks good. Thanks for keeping all the docs up to date! I didn't look at the data changes in the datasets packages, and the handful of docs/config changes in them were all fine.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Sorry, putting this back in review because I forgot what was involved in unhooking Jenkins from the old system. New PRs are ap_verify#148 and jenkins-dm-jobs#889.

            Show
            krzys Krzysztof Findeisen added a comment - Sorry, putting this back in review because I forgot what was involved in unhooking Jenkins from the old system. New PRs are ap_verify#148 and jenkins-dm-jobs#889 .
            Hide
            Parejkoj John Parejko added a comment -

            Thanks: your responses on the PRs satisfy my questions.

            Show
            Parejkoj John Parejko added a comment - Thanks: your responses on the PRs satisfy my questions.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              John Parejko
              Watchers:
              Eric Bellm, Ian Sullivan, John Parejko, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.