Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33163

Create the Common Repository for Hexapod and Rotator Controller Code

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      TSSW Sprint - Jan 03 - Jan 17, TSSW Sprint - Jan 17 - Jan 31
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Create the common repository for hexapod and rotator controller code. Right now, there are many duplication of code. This task is to try to put the common code into a repository to decrease the duplication.

        Attachments

          Activity

          Hide
          ttsai Te-Wei Tsai added a comment -

          Create a common repository for the hexapod and rotator controller: ts_hexrotpxicom.

          Show
          ttsai Te-Wei Tsai added a comment - Create a common repository for the hexapod and rotator controller: ts_hexrotpxicom .
          Hide
          ttsai Te-Wei Tsai added a comment -

          Please help to review this PR:
          https://github.com/lsst-ts/ts_hexrotpxicom/pull/1

          The codes in this PR are migrated from the ts_rotator_controller. The main differences are:
          1. Rewrite the make file to remove the hard-coded file name or directory name
          2. Remove the dependency of telemetry structure. Instead, use the size as the input to allocate the needed memory size. This can make sure the code can be applied to the rotator and hexapod controller codes. You can see there is a sizeTel input on telServer_initGui() and telServer_initDds().

          Thanks!

           

          Show
          ttsai Te-Wei Tsai added a comment - Please help to review this PR: https://github.com/lsst-ts/ts_hexrotpxicom/pull/1 The codes in this PR are migrated from the ts_rotator_controller . The main differences are: 1. Rewrite the make file to remove the hard-coded file name or directory name 2. Remove the dependency of telemetry structure. Instead, use the size as the input to allocate the needed memory size. This can make sure the code can be applied to the rotator and hexapod controller codes. You can see there is a sizeTel input on telServer_initGui() and  telServer_initDds() . Thanks!  
          Hide
          ttsai Te-Wei Tsai added a comment -

          Russell reviewed in Github already. Thanks!

          Show
          ttsai Te-Wei Tsai added a comment - Russell reviewed in Github already. Thanks!

            People

            Assignee:
            ttsai Te-Wei Tsai
            Reporter:
            ttsai Te-Wei Tsai
            Reviewers:
            Russell Owen
            Watchers:
            Russell Owen, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.