Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33212

SALPY historical tests are incorrect

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:

      Description

      The SALPY unit tests for historical data are mis-written: they allow new data to overwrite a cache of written samples, which makes it appear that the historical data returned is the most recent sample, even if the oldest sample is expected.

      Fix the tests and update associated comments in Java tests.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          rowen Russell Owen added a comment - - edited

          I also:

          • Updated the Java late-joiner tests to match. They do a bit more work now.
          • Updated Jenkinsfile to run the Java unit tests. This will fail until we have a new develop-env Docker image with an updated maven (Tiago Ribeiro is working on this now).
          • Updated the README.md with instructions for running unit tests.
          • Tweaked the version history entry for 6.0.1.

          Pull request: https://github.com/lsst-ts/ts_sal/pull/174

          Show
          rowen Russell Owen added a comment - - edited I also: Updated the Java late-joiner tests to match. They do a bit more work now. Updated Jenkinsfile to run the Java unit tests. This will fail until we have a new develop-env Docker image with an updated maven ( Tiago Ribeiro is working on this now). Updated the README.md with instructions for running unit tests. Tweaked the version history entry for 6.0.1. Pull request: https://github.com/lsst-ts/ts_sal/pull/174
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Wouter van Reeven
            Watchers:
            Petr Kubanek, Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.