Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33256

Remove Gen 2 support from verify

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: verify
    • Labels:

      Description

      Once neither AP nor DRP are running MetricTasks in Gen 2:

      • Remove the lsst.verify.gen2tasks.register and registerMultiple decorators from all MetricTasks throughout Science Pipelines.
      • Remove any inheritance from lsst.verify.gen2tasks.MetricTask from all MetricTasks throughout Science Pipelines.
      • Remove any reference to MetricsControllerTask from the documentation of individual MetricTasks (such as NumberNewDiaObjectsMetricTask).
      • Remove the lsst.verify.gen2tasks package.
      • Remove lsst.verify.tasks.TimeMethodMetricConfig.metric, which is not needed for PipelineTasks.
      • Review the lsst.verify documentation to ensure there is no remaining Gen 2 content.

      This ticket does not cover removing Job or its infrastructure, since we are currently still using it in Gen 3, but there may be non-obvious components that are bypassed in Gen 3 and should be removed now.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-31047 Remove configuration from obs_* packages after Gen2 removal

          • To Do
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33150 Remove Gen 2 support from ap_verify

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            For our final gen2 weekly reprocessings I still need to run:

            matchedVisitMetrics.py
            		 
            dispatch_verify.py

            Just making sure the removals outlined for this ticket either don't affect those, or can wait until sign-off.

            Show
            lauren Lauren MacArthur added a comment - For our final gen2 weekly reprocessings I still need to run: matchedVisitMetrics.py dispatch_verify.py Just making sure the removals outlined for this ticket either don't affect those, or can wait until sign-off.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            dispatch_verify.py was one of the things I was including under "Job-related infrastructure", so no worries there.

            I didn't know about matchedVisitMetrics.py, but I don't see any overt dependency on lsst.verify. It looks roughly similar in purpose to MetricsControllerTask, only not using MetricTask? If so, then I think it will be unaffected.

            Show
            krzys Krzysztof Findeisen added a comment - - edited dispatch_verify.py was one of the things I was including under " Job -related infrastructure", so no worries there. I didn't know about matchedVisitMetrics.py , but I don't see any overt dependency on lsst.verify . It looks roughly similar in purpose to MetricsControllerTask , only not using MetricTask ? If so, then I think it will be unaffected.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Great!  Thanks for checking...

            Show
            lauren Lauren MacArthur added a comment - Great!  Thanks for checking...
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            FTR, I've retroactively made PRs for all four branches.

            Show
            krzys Krzysztof Findeisen added a comment - FTR, I've retroactively made PRs for all four branches.
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Looks like you’ve got some rebasing to do .  Otherwise, with the caveat that I’m not at all familiar with this package, all looks ok to me, so a green Jenkins after rebasing & you’re good to go.

            Show
            lauren Lauren MacArthur added a comment - Looks like you’ve got some rebasing to do .  Otherwise, with the caveat that I’m not at all familiar with this package, all looks ok to me, so a green Jenkins after rebasing & you’re good to go.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Thanks for being willing to review this!

            Show
            krzys Krzysztof Findeisen added a comment - Thanks for being willing to review this!

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Lauren MacArthur
              Watchers:
              Ian Sullivan, Krzysztof Findeisen, Lauren MacArthur, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.