# Remove Gen 2 support from verify

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
4
• Sprint:
AP F22-3 (August)
• Team:
• Urgent?:
No

#### Description

Once neither AP nor DRP are running MetricTasks in Gen 2:

• Remove the lsst.verify.gen2tasks.register and registerMultiple decorators from all MetricTasks throughout Science Pipelines.
• Review the lsst.verify documentation to ensure there is no remaining Gen 2 content.

This ticket does not cover removing Job or its infrastructure, since we are currently still using it in Gen 3, but there may be non-obvious components that are bypassed in Gen 3 and should be removed now.

#### Activity

Hide
Lauren MacArthur added a comment -

For our final gen2 weekly reprocessings I still need to run:

 matchedVisitMetrics.py dispatch_verify.py 

Just making sure the removals outlined for this ticket either don't affect those, or can wait until sign-off.

Show
Lauren MacArthur added a comment - For our final gen2 weekly reprocessings I still need to run: matchedVisitMetrics.py dispatch_verify.py Just making sure the removals outlined for this ticket either don't affect those, or can wait until sign-off.
Hide
Krzysztof Findeisen added a comment - - edited

dispatch_verify.py was one of the things I was including under "Job-related infrastructure", so no worries there.

I didn't know about matchedVisitMetrics.py, but I don't see any overt dependency on lsst.verify. It looks roughly similar in purpose to MetricsControllerTask, only not using MetricTask? If so, then I think it will be unaffected.

Show
Krzysztof Findeisen added a comment - - edited dispatch_verify.py was one of the things I was including under " Job -related infrastructure", so no worries there. I didn't know about matchedVisitMetrics.py , but I don't see any overt dependency on lsst.verify . It looks roughly similar in purpose to MetricsControllerTask , only not using MetricTask ? If so, then I think it will be unaffected.
Hide
Lauren MacArthur added a comment -

Great!  Thanks for checking...

Show
Lauren MacArthur added a comment - Great!  Thanks for checking...
Hide
Krzysztof Findeisen added a comment -

FTR, I've retroactively made PRs for all four branches.

Show
Krzysztof Findeisen added a comment - FTR, I've retroactively made PRs for all four branches.
Hide
Lauren MacArthur added a comment -

Looks like you’ve got some rebasing to do .  Otherwise, with the caveat that I’m not at all familiar with this package, all looks ok to me, so a green Jenkins after rebasing & you’re good to go.

Show
Lauren MacArthur added a comment - Looks like you’ve got some rebasing to do .  Otherwise, with the caveat that I’m not at all familiar with this package, all looks ok to me, so a green Jenkins after rebasing & you’re good to go.
Hide
Krzysztof Findeisen added a comment -

Thanks for being willing to review this!

Show
Krzysztof Findeisen added a comment - Thanks for being willing to review this!

#### People

Assignee:
Krzysztof Findeisen
Reporter:
Krzysztof Findeisen
Reviewers:
Lauren MacArthur
Watchers:
Ian Sullivan, Krzysztof Findeisen, Lauren MacArthur, Simon Krughoff