Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33342

Gen3 Difference imaging does not support some config options

    XMLWordPrintable

    Details

    • Urgent?:
      No

      Description

      The gen3 difference imaging seems to have lost support for some options which are not supposed to be deprecated. For example:

      self.config.doAddCalexpBackground == True

      and also looking at the code it does not seem that

      self.config.doSubtract = False

      will work either. Similarly I do not see selectSources and templateSources being passed by the gen3 runQuantum method. 

      I have a fix for the `doAddCalexpBackground=True`, which I can send as a PR along with something which will also work for `doSubtract=False` . But I will need some background info on selectSources and templateSources.

       

      To give more information, when I use 

       imageDifferenceTildeVisits:
          class: lsst.pipe.tasks.imageDifference.ImageDifferenceFromTemplateTask
          config:
              doAddCalexpBackground: True
      

       

      I get an error for line:

       if self.config.doAddCalexpBackground:
          mi = exposure.getMaskedImage()
          mi += calexpBackgroundExposure.getImage()
      

       

      which says NoneType object has no getImage method, as the calexpBackgroundExposure is not passed by the runQuantum method.

        Attachments

          Activity

          Hide
          surhud Surhud More added a comment -

          Please see the corresponding pull request. 

           

          https://github.com/lsst/pipe_tasks/pull/624

          Show
          surhud Surhud More added a comment - Please see the corresponding pull request.    https://github.com/lsst/pipe_tasks/pull/624
          Hide
          surhud Surhud More added a comment -

          The above PR adds support for both doAddCalexpBackground=True and doSubtract=False. The other parameters are likely going to be deprecated: Yusra AlSayyad, please correct me if I am wrong.

          Show
          surhud Surhud More added a comment - The above PR adds support for both doAddCalexpBackground=True and doSubtract=False. The other parameters are likely going to be deprecated: Yusra AlSayyad , please correct me if I am wrong.

            People

            Assignee:
            surhud Surhud More
            Reporter:
            surhud Surhud More
            Reviewers:
            Sophie Reed, Yusra AlSayyad
            Watchers:
            Ian Sullivan, Sophie Reed, Surhud More, Yusra AlSayyad
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:

                Jenkins

                No builds found.