Gen3 Difference imaging does not support some config options

XMLWordPrintable

Details

• Type: Bug
• Status: In Review
• Resolution: Unresolved
• Fix Version/s: None
• Component/s:
• Labels:
• Urgent?:
No

Description

The gen3 difference imaging seems to have lost support for some options which are not supposed to be deprecated. For example:

and also looking at the code it does not seem that

self.config.doSubtract = False

will work either. Similarly I do not see selectSources and templateSources being passed by the gen3 runQuantum method.

I have a fix for the doAddCalexpBackground=True, which I can send as a PR along with something which will also work for doSubtract=False . But I will need some background info on selectSources and templateSources.

To give more information, when I use

  imageDifferenceTildeVisits:     class: lsst.pipe.tasks.imageDifference.ImageDifferenceFromTemplateTask     config:         doAddCalexpBackground: True 

I get an error for line:

  if self.config.doAddCalexpBackground:     mi = exposure.getMaskedImage()     mi += calexpBackgroundExposure.getImage() 

which says NoneType object has no getImage method, as the calexpBackgroundExposure is not passed by the runQuantum method.

Activity

Hide
Surhud More added a comment -

Please see the corresponding pull request.

Show
Surhud More added a comment - Please see the corresponding pull request.    https://github.com/lsst/pipe_tasks/pull/624
Hide
Surhud More added a comment -

The above PR adds support for both doAddCalexpBackground=True and doSubtract=False. The other parameters are likely going to be deprecated: Yusra AlSayyad, please correct me if I am wrong.

Show
Surhud More added a comment - The above PR adds support for both doAddCalexpBackground=True and doSubtract=False. The other parameters are likely going to be deprecated: Yusra AlSayyad , please correct me if I am wrong.

People

Assignee:
Surhud More
Reporter:
Surhud More
Reviewers:
Sophie Reed, Yusra AlSayyad
Watchers:
Ian Sullivan, Sophie Reed, Surhud More, Yusra AlSayyad