Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33351

Backport some improvements from kafka salobj to the normal branch

    XMLWordPrintable

    Details

      Description

      Back-port a few improvements from the Kafka experimental branch of ts_salobj to the normal branch, including:

      • set_random_lsst_dds_partition_prefix: use os.urandom in , so it cannot be seeded. This avoids any risk of duplicates while running tests in parallel.
      • base_csc_test_case: call random prefix generator in setUp().
      • SalInfo: add _closing flag and possibly a done_task. The problem with a single isclosed flag is that there is no way to tell the difference between "never opened" and opened and now closing or closed.
      • Consider a _closing flag or similar solution for other kinds of objects, as well.

      Also fix a few instances where library code is still using the deprecated salobj version of index_generator, instead of the version in ts_utils.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33192 Create prototype salobj using Kafka

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue is triggered by DM-33192 [ DM-33192 ]
            rowen Russell Owen made changes -
            Epic Link DM-27718 [ 442123 ]
            Sprint TSSW Sprint - Jan 17 - Jan 31 [ 1144 ]
            rowen Russell Owen made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            It turns out that the existing "isopen" attribute works exactly like a "closing" flag. Which means I should look more closely at the Kafka branch. Meanwhile I updated the docs and expanded SalInfo.start to raise if already closing or closed.

            Pull request: https://github.com/lsst-ts/ts_salobj/pull/222

            Show
            rowen Russell Owen added a comment - - edited It turns out that the existing "isopen" attribute works exactly like a "closing" flag. Which means I should look more closely at the Kafka branch. Meanwhile I updated the docs and expanded SalInfo.start to raise if already closing or closed. Pull request: https://github.com/lsst-ts/ts_salobj/pull/222
            rowen Russell Owen made changes -
            Reviewers Wouter van Reeven [ wvreeven ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            Reviewed on GitHub.

            Show
            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.
            wvreeven Wouter van Reeven made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Typo fixed. Merged to develop. I'll hold off release for a bit, to see if any problems show up while testing the new cycle build.

            Show
            rowen Russell Owen added a comment - Typo fixed. Merged to develop. I'll hold off release for a bit, to see if any problems show up while testing the new cycle build.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.