Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33351

Backport some improvements from kafka salobj to the normal branch

    XMLWordPrintable

Details

    Description

      Back-port a few improvements from the Kafka experimental branch of ts_salobj to the normal branch, including:

      • set_random_lsst_dds_partition_prefix: use os.urandom in , so it cannot be seeded. This avoids any risk of duplicates while running tests in parallel.
      • base_csc_test_case: call random prefix generator in setUp().
      • SalInfo: add _closing flag and possibly a done_task. The problem with a single isclosed flag is that there is no way to tell the difference between "never opened" and opened and now closing or closed.
      • Consider a _closing flag or similar solution for other kinds of objects, as well.

      Also fix a few instances where library code is still using the deprecated salobj version of index_generator, instead of the version in ts_utils.

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment - - edited

            It turns out that the existing "isopen" attribute works exactly like a "closing" flag. Which means I should look more closely at the Kafka branch. Meanwhile I updated the docs and expanded SalInfo.start to raise if already closing or closed.

            Pull request: https://github.com/lsst-ts/ts_salobj/pull/222

            rowen Russell Owen added a comment - - edited It turns out that the existing "isopen" attribute works exactly like a "closing" flag. Which means I should look more closely at the Kafka branch. Meanwhile I updated the docs and expanded SalInfo.start to raise if already closing or closed. Pull request: https://github.com/lsst-ts/ts_salobj/pull/222

            Reviewed on GitHub.

            wvreeven Wouter van Reeven added a comment - Reviewed on GitHub.

            Typo fixed. Merged to develop. I'll hold off release for a bit, to see if any problems show up while testing the new cycle build.

            rowen Russell Owen added a comment - Typo fixed. Merged to develop. I'll hold off release for a bit, to see if any problems show up while testing the new cycle build.

            People

              rowen Russell Owen
              rowen Russell Owen
              Wouter van Reeven
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.