Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33426

cp_verify overscan read noise checks should use absolute value

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Invalid
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      0
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The current tests are:

       if ((overscanReadNoise - readNoise)/readNoise > 0.05)
      # and
      verify['NOISE'] = bool(np.abs(stats['NOISE'] - readNoise)/readNoise <= 0.05)}}
      

      We debated if we should fail if the measured noise is smaller than the read noise, and decided we should, because that means something is seriously wrong (and is what DMTN-101 states). That justifies the second np.abs. If the overscan read noise is lower (the case that came up), then we get NOISE=False, CONSISTENT=True. If the overscan RN is high, then we get CONSISTENT=False and possibly NOISE=True (we measured the higher read noise).

      It would be more understandable if the CONSISTENT check had the absolute value as well, so we note when the quoted read noise is lower than what is observed from the ovrescan.

        Attachments

          Activity

          Hide
          czw Christopher Waters added a comment -

          This was fixed correctly on DM-39138.

          Show
          czw Christopher Waters added a comment - This was fixed correctly on DM-39138 .

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            czw Christopher Waters
            Watchers:
            Andrés Alejandro Plazas Malagón, Christopher Waters
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.