Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33440

need to fix ap_verify for changes in DM-32988

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S22-3 (February)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      As part of DM-32988 we updated ap_pipe and the usual ap_verify datasets to use multi-tract image differencing as the default, but missed a couple of required changes to ap_verify.yaml. This ticket is to implement those.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32988 Update all ApPipe pipelines to use multi-tract difference imaging

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kherner Kenneth Herner added a comment -

            Things we need to do are:

            1. change imageDifferenceNoFakes and imageDifference to use the ImageDifferenceFromTemplateTask
            2. add doWriteWarpedExp: true to imageDifference (only in the no fakes version now)
            3. change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. That may also need an additional parameter added.
            Show
            kherner Kenneth Herner added a comment - Things we need to do are: change imageDifferenceNoFakes and imageDifference to use the ImageDifferenceFromTemplateTask add doWriteWarpedExp: true to imageDifference (only in the no fakes version now) change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. That may also need an additional parameter added.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment - - edited

            change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place.

            Looking at ap_pipe#99, I think that's just connections.inputTemplate: parameters.templateExp. It should be automatically reflected in the dataset-specific pipelines.

            Show
            krzys Krzysztof Findeisen added a comment - - edited change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. Looking at ap_pipe#99 , I think that's just connections.inputTemplate: parameters.templateExp . It should be automatically reflected in the dataset-specific pipelines.

              People

              Assignee:
              kherner Kenneth Herner
              Reporter:
              kherner Kenneth Herner
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Kenneth Herner, Kian-Tat Lim, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.