Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33440

need to fix ap_verify for changes in DM-32988

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • ap_verify
    • None
    • 1
    • AP S22-3 (February)
    • Alert Production
    • No

    Description

      As part of DM-32988 we updated ap_pipe and the usual ap_verify datasets to use multi-tract image differencing as the default, but missed a couple of required changes to ap_verify.yaml. This ticket is to implement those.

      Attachments

        Issue Links

          Activity

            Things we need to do are:

            1. change imageDifferenceNoFakes and imageDifference to use the ImageDifferenceFromTemplateTask
            2. add doWriteWarpedExp: true to imageDifference (only in the no fakes version now)
            3. change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. That may also need an additional parameter added.
            kherner Kenneth Herner added a comment - Things we need to do are: change imageDifferenceNoFakes and imageDifference to use the ImageDifferenceFromTemplateTask add doWriteWarpedExp: true to imageDifference (only in the no fakes version now) change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. That may also need an additional parameter added.
            krzys Krzysztof Findeisen added a comment - - edited

            change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place.

            Looking at ap_pipe#99, I think that's just connections.inputTemplate: parameters.templateExp. It should be automatically reflected in the dataset-specific pipelines.

            krzys Krzysztof Findeisen added a comment - - edited change config settings in both imageDifference and imageDifferenceNoFakes as appropriate to make sure the retrieveTemplate task outputs are going to the right place. Looking at ap_pipe#99 , I think that's just connections.inputTemplate: parameters.templateExp . It should be automatically reflected in the dataset-specific pipelines.

            People

              kherner Kenneth Herner
              kherner Kenneth Herner
              Krzysztof Findeisen
              Kenneth Herner, Kian-Tat Lim, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.