Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33453

Update ap_pipe pipelines to match drp_pipe naming

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      AP S22-3 (February), AP S22-4 (March), AP S22-5 (April), AP S22-6 (May), AP F23-3 (August), AP F23-4 (September)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Thanks to DM-30891, we have drp_pipe. Discussion on GitHub landed on a slightly different subdirectory naming structure for camera-specific pipelines than ap_pipe currently uses. This ticket is to update ap_pipe and ap_verify to the following, and verify they are consistent with drp_pipe:

      • [PACKAGE]/pipelines
        • DECam
        • HSC
        • LSSTCam-imSim
        • LSSTCam

      Some thought should be given to backwards compatibility so we don't immediately break everyone's pipeline imports without warning.

        Attachments

          Issue Links

            Activity

            Hide
            krzys Krzysztof Findeisen added a comment -

            Will this ticket also cover ap_verify, which has a parallel structure to ap_pipe?

            Show
            krzys Krzysztof Findeisen added a comment - Will this ticket also cover ap_verify , which has a parallel structure to ap_pipe ?
            Hide
            mrawls Meredith Rawls added a comment -

            Good call - yes, we should update both. Will edit description accordingly.

            Show
            mrawls Meredith Rawls added a comment - Good call - yes, we should update both. Will edit description accordingly.
            Hide
            sullivan Ian Sullivan added a comment -

            Note that there is additional detail and emphasis on following the naming convention laid out in RFC-775 on DM-36796, which I am closing as a duplicate of this ticket.

            Show
            sullivan Ian Sullivan added a comment - Note that there is additional detail and emphasis on following the naming convention laid out in RFC-775 on DM-36796 , which I am closing as a duplicate of this ticket.
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            Adding the "is triggered by" link for RFC-775. It was included in DM-36796, but not in this issue.

            Also, a reminder that, according to DM-36796, there is not only code but also documentation that uses the old paths.

            Show
            krzys Krzysztof Findeisen added a comment - - edited Adding the "is triggered by" link for RFC-775 . It was included in DM-36796 , but not in this issue. Also, a reminder that, according to DM-36796 , there is not only code but also documentation that uses the old paths.
            Show
            howarde7 Erin Howard added a comment - https://github.com/lsst/ap_verify/pull/203 https://github.com/lsst/ap_verify_ci_hits2015/pull/51 https://github.com/lsst/ap_verify_ci_cosmos_pdr2/pull/38 https://github.com/lsst/ap_verify_ci_dc2/pull/7 https://github.com/lsst/ap_verify_testdata/pull/37 https://github.com/lsst/ap_pipe/pull/150 https://github.com/lsst/meas_transiNet/pull/19 https://github.com/lsst/pipelines_lsst_io/pull/271   And Jenkins: https://rubin-ci.slac.stanford.edu/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/258/pipeline/   Thank you!
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            I don't see a PR for ap_verify_dataset_template? Its example pipelines also use the old naming scheme.

            Show
            krzys Krzysztof Findeisen added a comment - - edited I don't see a PR for ap_verify_dataset_template ? Its example pipelines also use the old naming scheme.
            Hide
            krzys Krzysztof Findeisen added a comment - - edited

            I found two more places where we're still using the old names:

            Show
            krzys Krzysztof Findeisen added a comment - - edited I found two more places where we're still using the old names: https://github.com/lsst/obs_decam/blob/main/doc/lsst.obs.decam/using-obs-decam.rst has some very out-of-date references to how we will have been going to implement RFC-775 . The pipelines in https://github.com/lsst-dm/prompt_prototype/tree/main/pipelines are tweaks of the ap_pipe ones.

              People

              Assignee:
              howarde7 Erin Howard
              Reporter:
              mrawls Meredith Rawls
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Erin Howard, Ian Sullivan, Krzysztof Findeisen, Meredith Rawls
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.