Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33464

Update headers in postISRCCD

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_isr
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Team:
      Data Release Production

      Description

      ISR is leaving the `CCDGAIN` and `CCDNOISE` header keywords in LSSTCam, which are not the actual gain used.  When the variance is constructed, we should populate keywords with the actual gain and read noise values used.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          tjenness Tim Jenness added a comment -

          I would prefer that if we write new headers we use HIERARCH LSST CCDGAIN or something similar. We have caused real confusion in the past by writing headers that match one specific instrument but not another and someone reading a header can't really be sure whether it was a propagated header or something added by the pipeline.

          I'd be in favor of not touching the existing headers at all – you don't want to start having to know all possible variants for GAIN information and it would be better to follow RFC-576 – we pass everything to the output and augment headers with items that are explicitly processing headers.

          Show
          tjenness Tim Jenness added a comment - I would prefer that if we write new headers we use HIERARCH LSST CCDGAIN or something similar. We have caused real confusion in the past by writing headers that match one specific instrument but not another and someone reading a header can't really be sure whether it was a propagated header or something added by the pipeline. I'd be in favor of not touching the existing headers at all – you don't want to start having to know all possible variants for GAIN information and it would be better to follow RFC-576 – we pass everything to the output and augment headers with items that are explicitly processing headers.
          Hide
          Permalink
          czw Christopher Waters added a comment -

          https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37667/pipeline

          Show
          czw Christopher Waters added a comment - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37667/pipeline

            People

            Assignee:
            czw Christopher Waters
            Reporter:
            czw Christopher Waters
            Reviewers:
            Tim Jenness
            Watchers:
            Christopher Waters, Robert Lupton, Tim Jenness, Yousuke Utsumi
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.