Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33566

Make sure write_from sends all structs together

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:

      Description

      The write_from function in ts_tcpip sends a collection of structs. However, it calls await writer.drain() after each struct, which makes a race condition with any other task that writes data to the same socket.

      Fix by writing all structs before calling drain.

        Attachments

          Activity

          Hide
          rowen Russell Owen added a comment -
          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_tcpip/pull/11
          Hide
          ttsai Te-Wei Tsai added a comment -

          Reviewed in GitHub.

          Show
          ttsai Te-Wei Tsai added a comment - Reviewed in GitHub.
          Hide
          rowen Russell Owen added a comment -

          Tagged v0.3.6

          Show
          rowen Russell Owen added a comment - Tagged v0.3.6

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Te-Wei Tsai
            Watchers:
            Russell Owen, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.