Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33568

Cleanup the ts_sal Jenkinsfile

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ts_middleware
    • Labels:
      None

      Description

      I think the ts_sal/Jenkinsfile needs some attention.  It looks like there is some duplication between the C++ and Java unit test stages; both are generating the Script and Test libraries.  I recommend splitting the salgenerator steps out into a separate stage and NOT running them in the unit test stages.

      Additionally, to make parsing the Jenkins build console-output easier, instead of the using a single docker exec command with multiple command separators (&&), split it up into multiple docker exec commands.  That way the commands bookend the processes and make debugging easier.

        Attachments

          Issue Links

            Activity

            Hide
            rbovill Rob Bovill added a comment -

            Disregard the comments regarding the docker exec commands.  They execute in shell (sh -s) which makes the changes not persist across commands.

            I do think we need to find a way to build the libraries in a separate stage and then run the unit-tests each in separate stages, in order to reduce runtime and redundancy.

            Show
            rbovill Rob Bovill added a comment - Disregard the comments regarding the docker exec commands.  They execute in shell (sh -s) which makes the changes not persist across commands. I do think we need to find a way to build the libraries in a separate stage and then run the unit-tests each in separate stages, in order to reduce runtime and redundancy.
            Hide
            dmills Dave Mills added a comment -

            Streamlined Jenkinsfile

            Show
            dmills Dave Mills added a comment - Streamlined Jenkinsfile
            Hide
            rbovill Rob Bovill added a comment -

            Jenkinsfile looks much better and is more efficient. Work complete.

            Show
            rbovill Rob Bovill added a comment - Jenkinsfile looks much better and is more efficient. Work complete.

              People

              Assignee:
              dmills Dave Mills
              Reporter:
              rbovill Rob Bovill
              Reviewers:
              Rob Bovill
              Watchers:
              Dave Mills, Petr Kubanek, Rob Bovill, Tiago Ribeiro, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.