Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33586

Update photodiode correction to use butler photodiode data

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • cp_pipe
    • None

    Description

      DM-33297 is adding a photodiode correction term, but the photodiode data isn't ingested yet.  This ticket will update that code once the photodiode data is ingested.

      Attachments

        Issue Links

          Activity

            I've added a lookup function to sort out the PTC issue.  I've quickly confirmed that the output linearity is identical before this commit and after (the collections are u/czw/DM-33586/test.20221208a for before and u/czw/DM-33586/test.20221209a after), and I'm running a local copy of ci_cpp to confirm that this ensures that can run as well (the dimension change means I can't run a test against an already complete ci_cpp repo).

            Let me know if there's still any issues.

            # Test command:
            pipetask --long-log run -b /repo/main \
                     -i u/jchiang/ptc_0_13144_w_2022_39,LSSTCam/photodiode \
                     -d "instrument='LSSTCam' and exposure.science_program='13144' and detector=90" \
                     -o u/czw/DM-33586/test.20221209a \
                     -p $CP_PIPE_DIR/pipelines/cpLinearityCorrected.yaml
             

             

            czw Christopher Waters added a comment - I've added a lookup function to sort out the PTC issue.  I've quickly confirmed that the output linearity is identical before this commit and after (the collections are u/czw/ DM-33586 /test.20221208a for before and u/czw/ DM-33586 /test.20221209a  after), and I'm running a local copy of ci_cpp  to confirm that this ensures that can run as well (the dimension change means I can't run a test against an already complete ci_cpp repo). Let me know if there's still any issues. # Test command: pipetask -- long -log run -b /repo/main \ -i u/jchiang/ptc_0_13144_w_2022_39,LSSTCam/photodiode \ -d "instrument='LSSTCam' and exposure.science_program='13144' and detector=90" \ -o u/czw/DM- 33586 /test.20221209a \ -p $CP_PIPE_DIR/pipelines/cpLinearityCorrected.yaml  
            jchiang James Chiang added a comment -

            Thanks, czw!  I've run it as well, using multiple detectors, and everything looks good.

            jchiang James Chiang added a comment - Thanks, czw !  I've run it as well, using multiple detectors, and everything looks good.

            Thank you both for implementing my previous comments and for the work on this. Things look good to me and it seems that tests pass, according to the messages above. I'll run on Jenkins and if things look OK after that I'll merge.

            plazas Andrés Alejandro Plazas Malagón added a comment - Thank you both for implementing my previous comments and for the work on this. Things look good to me and it seems that tests pass, according to the messages above. I'll run on Jenkins and if things look OK after that I'll merge.
            plazas Andrés Alejandro Plazas Malagón added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/37735/pipeline

            As a note for posterity, I did some initial work on this ticket (in particular, ingesting some photodiode data) and that's why it is assigned to me, but the latest changes were implemented by Jim Chiang and Chris Waters. Today I caught up with these changes and reviewed them.

            plazas Andrés Alejandro Plazas Malagón added a comment - As a note for posterity, I did some initial work on this ticket (in particular, ingesting some photodiode data) and that's why it is assigned to me, but the latest changes were implemented by Jim Chiang and Chris Waters. Today I caught up with these changes and reviewed them.

            People

              plazas Andrés Alejandro Plazas Malagón
              czw Christopher Waters
              Andrés Alejandro Plazas Malagón, Christopher Waters, Craig Lage, James Chiang, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.