Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33727

Allow sconsUtils to pass tests when the user has a pytest.ini

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: sconsUtils
    • Labels:
      None
    • Story Points:
      0.1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      https://github.com/lsst/sconsUtils/issues/100 reports that when they have a pytest.ini in a parent directory the sconsUtils tests fail. Turns out that sconsUtils is the only package we have that doesn't have a pytest configuration in setup.cfg – adding such a config fixes the problem.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            I tried to do a build with a pytest.ini file in my directory tree and the first failure is spectractor because it does not have any pytest configuration with it (looks like it's assuming nose tests). Should we add an empty pytest.ini to our branch? cc/ Merlin Fisher-Levine

            Show
            tjenness Tim Jenness added a comment - I tried to do a build with a pytest.ini file in my directory tree and the first failure is spectractor because it does not have any pytest configuration with it (looks like it's assuming nose tests). Should we add an empty pytest.ini to our branch? cc/ Merlin Fisher-Levine
            Hide
            tjenness Tim Jenness added a comment -

            The rest of lsst_distrib built without issue.

            Show
            tjenness Tim Jenness added a comment - The rest of lsst_distrib built without issue.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            I think the nose stuff is actually not active, that was only when it was eupspkg, now that it's a sconsUtils package I don't think it gets run with nose. But I think this needs to wait until Eli has helped me fix the basic build problems there and that's all running cleanly. Should be later today though, god willing...

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - I think the nose stuff is actually not active, that was only when it was eupspkg, now that it's a sconsUtils package I don't think it gets run with nose. But I think this needs to wait until Eli has helped me fix the basic build problems there and that's all running cleanly. Should be later today though, god willing...
            Hide
            ktl Kian-Tat Lim added a comment -

            I believe it's now gone back to nose tests, so an empty pytest.ini might be a good idea. But if we're going to need this for any third-party forked package, we should document that in the Dev Guide.

            Show
            ktl Kian-Tat Lim added a comment - I believe it's now gone back to nose tests, so an empty pytest.ini might be a good idea. But if we're going to need this for any third-party forked package, we should document that in the Dev Guide.
            Hide
            ktl Kian-Tat Lim added a comment -

            This change to sconsUtils is fine.

            Show
            ktl Kian-Tat Lim added a comment - This change to sconsUtils is fine.
            Hide
            mfisherlevine Merlin Fisher-Levine added a comment -

            Thanks KT, this was on my list to follow up on once I'd finally converged, which I've now done at last. And yes, we're back to nosetests.

            Show
            mfisherlevine Merlin Fisher-Levine added a comment - Thanks KT, this was on my list to follow up on once I'd finally converged, which I've now done at last. And yes, we're back to nosetests.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Kian-Tat Lim, Merlin Fisher-Levine, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.