Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33794

Fix the Bug that the Client Need to Send Twice of clearError Command

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      TSSW Sprint - Feb 28 - Mar 14, TSSW Sprint - Mar 14 - Mar 28
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Fix the bug that the client needs to send twice of clearError command. This needs to modify the hexapod and rotator controller codes.

        Attachments

          Issue Links

          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34410 MTHexapod and MTRotator: stop sending clearError twice to the low-level controller

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment - - edited

            In ts_rotator_controller, the following global variables are involved in the clearError command: gInterlockOpen, gDriveFault, and gLinearEncFault. All of them are volatile and independent.

            Show
            ttsai Te-Wei Tsai added a comment - - edited In ts_rotator_controller , the following global variables are involved in the clearError command: gInterlockOpen , gDriveFault , and gLinearEncFault . All of them are volatile and independent.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Issue SUMMIT-6249 to test.

            Show
            ttsai Te-Wei Tsai added a comment - Issue SUMMIT-6249 to test.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Tested the update camera hexapod software on summit. Right now, the EUI will not need to do the clearError for the interlock fault but there is no signal actually.

            I ran the EUI of camera hexapod again to make sure this behavior.

            Show
            ttsai Te-Wei Tsai added a comment - Tested the update camera hexapod software on summit. Right now, the EUI will not need to do the clearError for the interlock fault but there is no signal actually. I ran the EUI of camera hexapod again to make sure this behavior.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            I realized there is the bug in the EUI that it will take over the control again after putting the control to CSC. This is because when the people clicks the stop button, it will issue the command to put the system back to a specific state. Need to fix this.

            Show
            ttsai Te-Wei Tsai added a comment - I realized there is the bug in the EUI that it will take over the control again after putting the control to CSC. This is because when the people clicks the stop button, it will issue the command to put the system back to a specific state. Need to fix this.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Fixed the GUIs and deployed them on summit.

            Show
            ttsai Te-Wei Tsai added a comment - Fixed the GUIs and deployed them on summit.
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PRs:
            1. https://github.com/lsst-ts/ts_hexapod_controller/pull/34
            2. https://github.com/lsst-ts/ts_rotator_controller/pull/36
            3. https://github.com/lsst-ts/ts_hexapod_gui/pull/23
            4. https://github.com/lsst-ts/ts_rotator_gui/pull/21

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_hexapod_controller/pull/34 2. https://github.com/lsst-ts/ts_rotator_controller/pull/36 3. https://github.com/lsst-ts/ts_hexapod_gui/pull/23 4. https://github.com/lsst-ts/ts_rotator_gui/pull/21 Thanks!
            Hide
            Permalink
            ttsai Te-Wei Tsai added a comment -

            Thanks Russell reviewed the PRs in GitHub.

            Show
            ttsai Te-Wei Tsai added a comment - Thanks Russell reviewed the PRs in GitHub.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.