Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: daf_butler
-
Labels:
-
Story Points:0.1
-
Epic Link:
-
Sprint:DB_S22_12
-
Team:Data Access and Database
-
Urgent?:No
Description
Browsing through the code I noticed a piece of code that does not make much sense: https://github.com/lsst/daf_butler/blob/main/python/lsst/daf/butler/registry/databases/sqlite.py#L264-L269
try:
|
return engine
|
except sqlalchemy.exc.OperationalError as err:
|
raise RuntimeError(
|
f"Error creating connection with uri='{uri}', filename='{filename}', target={target}."
|
) from err
|
The try block is not going to throw ever, so the whole try/except is not needed. This came from my own changes in DM-26302.
Attachments
Issue Links
- is triggered by
-
DM-26302 Avoid requiring long-lived per-Database-instance connections
- Done
Tim Jenness, thanks for review! Jenkins is happy, merged.