Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33817

Enable mypy checking in ctrl_mpexec

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      This is a continuation of DM-32250, which I'm halting work on short of its original goal to focus on other priorities.

      At present, adding mypy checking ctrl_mpexec can't quite use the same formula as the other middleware packages, because one of its dependences (obs_base) is not yet pip-installable.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33488 Add deletion support to LimitedButler and QuantumBackedButler

          • Done
          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-809 Require black+isort formatting and mypy checking in middleware packages

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32250 Enable mypy checking in pipe_base and obs_base

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            I feel that I'm missing mypy in daf_butler while I'm messing with DM-33488 interface changes. It should be easy to add, obs_base is no longer a dependency.

            Show
            salnikov Andy Salnikov added a comment - I feel that I'm missing mypy in daf_butler while I'm messing with DM-33488 interface changes. It should be easy to add, obs_base is no longer a dependency.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Tim Jenness, could you check these two PRs:

            • pipe_base - tiny change for execution butler build method annotations
            • ctrl_mpexec - lots of changes, mostly adding trivial type annotations, but I had to change logic slightly in few places to make mypy happy

            Jenkins looks happy.

            Show
            salnikov Andy Salnikov added a comment - Tim Jenness , could you check these two PRs: pipe_base - tiny change for execution butler build method annotations ctrl_mpexec - lots of changes, mostly adding trivial type annotations, but I had to change logic slightly in few places to make mypy happy Jenkins looks happy.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks okay. MYPYPATH and py.typed need to be added to ctrl_mpexec.

            Show
            tjenness Tim Jenness added a comment - Looks okay. MYPYPATH and py.typed need to be added to ctrl_mpexec.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Tim Jenness
              Watchers:
              Andy Salnikov, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.