Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33826

ci_hsc_gen2 fails due to exception type change

    XMLWordPrintable

    Details

    • Story Points:
      0.25
    • Sprint:
      DB_S22_12
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      DM-33600 causes DataIdValueError to be thrown instead of LookupError. The except clause in https://github.com/lsst/obs_base/blob/main/python/lsst/obs/base/gen2to3/convertRepo.py#L566 fails as a result. This causes ci_hsc_gen2 to fail:

      :::::  [2022-02-28T07:08:34.853089Z]     convertRepoTask.run(
      :::::  [2022-02-28T07:08:34.854223Z]   File "/j/ws/scipipe/ci_hsc/centos-7-conda/lsstsw/stack/lsst-scipipe-2.0.0/Linux64/obs_base/g3ddc52a869+3d529bba34/python/lsst/obs/base/gen2to3/convertRepo.py", line 746, in run
      :::::  [2022-02-28T07:08:34.854554Z]     self.registerUsedSkyMaps(rootConverter.subset)
      :::::  [2022-02-28T07:08:34.855790Z]   File "/j/ws/scipipe/ci_hsc/centos-7-conda/lsstsw/stack/lsst-scipipe-2.0.0/Linux64/obs_base/g3ddc52a869+3d529bba34/python/lsst/obs/base/gen2to3/convertRepo.py", line 565, in registerUsedSkyMaps
      :::::  [2022-02-28T07:08:34.856165Z]     self.butler3.registry.expandDataId(skymap=struct.name)
      :::::  [2022-02-28T07:08:34.857347Z]   File "/j/ws/scipipe/ci_hsc/centos-7-conda/lsstsw/stack/lsst-scipipe-2.0.0/Linux64/daf_butler/ge5b471c7cb+06320d0d81/python/lsst/daf/butler/registries/sql.py", line 746, in expandDataId
      :::::  [2022-02-28T07:08:34.857526Z]     raise DataIdValueError(
      :::::  [2022-02-28T07:08:34.858465Z] lsst.daf.butler.registry._exceptions.DataIdValueError: Could not fetch record for required dimension skymap via keys {'skymap': 'discrete/ci_hsc'}.
      

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            My fault, forgot to test ci_hsc_gen2. I'll fix it ASAP.

            Show
            salnikov Andy Salnikov added a comment - My fault, forgot to test ci_hsc_gen2. I'll fix it ASAP.
            Hide
            salnikov Andy Salnikov added a comment -

            Trivial bug fix, self-reviewed and merged.

            Show
            salnikov Andy Salnikov added a comment - Trivial bug fix, self-reviewed and merged.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              ktl Kian-Tat Lim
              Watchers:
              Andy Salnikov, Jim Bosch, Kian-Tat Lim
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.