Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_extensions_shapeHSM
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:Science Pipelines DM-W16-3
-
Team:Data Release Production
Description
The HSM shear estimation has received several improvements and important bugfixes on the HSC side that need to be ported to LSST. This is complicated by the fact that much of the code has been entirely rewritten on the LSST side to work within the new measurement framework, but we've also synchronized this package with the HSC side much more frequently than with other packages.
Attachments
Issue Links
- mentioned in
-
Page Loading...
Activity
I dont see any pull requests on that github repo....
Nate Lust: I take it the fact that this is "done" and merged means you managed to track down the review comments? Could you
add a link to them here for posterity, please?
The review comments were made on the commits themselves, so after I addressed the comments and rebased, the comments seem to be lost from github.
I accept Paul's statement that the unit test is adequate, though in general, I wish we have more complete tests for when we port algorithm changes.
I had two questions which are probably my lack of understanding of how the algorithms work. Please answer them, but if you are sure the code is right, go ahead and check in.
I think that the change to the unit test to add the centroid algorithm is my only actual complaint in this set of changes, so please see the pull request.