Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3387

Make use of good pixel count when building CoaddPsfs

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None

      Description

      When building a CoaddPsf we have the ability to take account of the number of pixels contributed by the inputs (see http://ls.st/paj and DM-3258). However, the CoaddPsf constructor fails to use this information. It should copy this field when copying the provided ExposureCatalog, so that computeAveragePosition can use it.

        Attachments

          Issue Links

            Activity

            Hide
            rowen Russell Owen added a comment -

            Implemented in meas_algorithms tickets/DM-3387, including a test case in tests/CoaddPsf.py.

            Show
            rowen Russell Owen added a comment - Implemented in meas_algorithms tickets/ DM-3387 , including a test case in tests/CoaddPsf.py.
            Hide
            swinbank John Swinbank added a comment -

            These changes look good: thanks! I added a few comments to the PR on GitHub, but there's nothing substantial there. I do think you might spend a few seconds reworking the repeated use of "if available" in comments & commit messages for clarity, but, other than that, good to merge.

            Show
            swinbank John Swinbank added a comment - These changes look good: thanks! I added a few comments to the PR on GitHub, but there's nothing substantial there. I do think you might spend a few seconds reworking the repeated use of "if available" in comments & commit messages for clarity, but, other than that, good to merge.
            Hide
            rowen Russell Owen added a comment -

            Thank you for the quick review. I made most of the requested cleanups (I did not camel-ify the variable names in the unit test since I felt it would be too disruptive for existing code and, in most cases, reduce readability). Cleaning up the commit message took some thought.

            I'll merge after one last Jenkins build (which may take awhile since a release is occurring).

            Show
            rowen Russell Owen added a comment - Thank you for the quick review. I made most of the requested cleanups (I did not camel-ify the variable names in the unit test since I felt it would be too disruptive for existing code and, in most cases, reduce readability). Cleaning up the commit message took some thought. I'll merge after one last Jenkins build (which may take awhile since a release is occurring).

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              swinbank John Swinbank
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.