Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33890

certifyCalibrations fails due to exception type change.

    XMLWordPrintable

    Details

    • Story Points:
      0.1
    • Sprint:
      DB_S22_12
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      One more problem due to fallout from the exception type "improvement" in DM-33600. certify-calibrations fails with this traceback:

      lsst.daf.butler.cli.utils ERROR: Caught an exception, details are in traceback:
      Traceback (most recent call last):
        File "lsst/daf/butler/cli/cmd/commands.py", line 530, in certify_calibrations
          script.certifyCalibrations(*args, **kwargs)
        File "lsst/daf/butler/script/certifyCalibrations.py", line 66, in certifyCalibrations
          input_collection = next(iter(registry.getCollectionChain(input_collection)))
        File "lsst/daf/butler/registries/sql.py", line 359, in getCollectionChain
          raise CollectionTypeError(f"Collection '{parent}' has type {record.type.name}, not CHAINED.")
      lsst.daf.butler.registry._exceptions.CollectionTypeError: Collection '20220302' has type RUN, not CHAINED.
      

      certifyCalibrations script has a check for TypeError: https://github.com/lsst/daf_butler/blob/main/python/lsst/daf/butler/script/certifyCalibrations.py#L65-L69
      this needs a change to CollectionTypeError.

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            Tatiana Goldina, thanks for testing my fix. Self-reviewed and merged. Sorry again for missing this in the original ticket.

            Show
            salnikov Andy Salnikov added a comment - Tatiana Goldina , thanks for testing my fix. Self-reviewed and merged. Sorry again for missing this in the original ticket.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Watchers:
              Andy Salnikov, Tatiana Goldina
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.