Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33911

Test the performance of refactored image differencing

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      AP F22-1 (June), AP F22-2 (July), AP F22-3 (August)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Similar to DM-31884, but this time characterizing the performance of image differencing using the refactored pipeline.

      In order to claim milestone DM-AP-12, we need to test whether "The Alert Generation science payload is now agnostic to the PSF of the template, as described in LDM-151 [25] §3.2.4. This represents an initial capability, providing realistic interfaces, data-flows and products; ongoing refinement of the algorithm being used is expected."
      A good test would be to identify the DECam visits from the Image Differencing Sprint that have worse seeing than the "best seeing" coadds but better than the "middle seeing" coadds. Use the "middle seeing" coadds in science image convolution mode, and the "best seeing" coadds in template convolution mode. The results should be equivalent.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35283 Process Diffim sprint dataset with new Image Differencing

          • Done
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. DM-35337 Extra argument in addSkySources call in detectAndMeasure.py

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35175 Debug convolveScience option of new image differencing

          • Done
          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34008 Test the performance of difference imaging

          • Invalid

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35172 Run the diffim sprint dataset through the refactored imageDifference code

          • Invalid
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35707 Investigate excess diaSources in the wings of bright stars

          • To Do

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34786 Run ci_hits with the new image differencing

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34801 Replace Diff_warpedExp with Diff_templateExp in diaPipe

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-35706 Analyze diaSources in patch centers with new diffim

          • Invalid

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-866 Adopt new Image Differencing task

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Yes, please do start a run with forceCompatibility=True. I will hopefully have the option to convolve the science image working on DM-35175 soon, but we want the run with compatibility mode turned on in any case.

            Show
            sullivan Ian Sullivan added a comment - Yes, please do start a run with forceCompatibility=True . I will hopefully have the option to convolve the science image working on DM-35175 soon, but we want the run with compatibility mode turned on in any case.
            Hide
            Permalink
            kherner Kenneth Herner added a comment -

            As mentioned earlier today, everything seems to be running well except for the diaPipe step. The error I'm getting is of the form

             

            ERROR 2022-06-19T01:07:07.411-05:00 lsst.ctrl.mpexec.singleQuantumExecutor (diaPipe:{instrument: 'HSC', detector: 50, visit: 1218, ...})(singleQuantumExecutor.py:220) - Execution of task 'diaPipe' on quantum {instrument: 'HSC', detector: 50, visit: 1218, ...} failed. Exception RuntimeError: Database query failed to load DiaObjects; did you call make_apdb.py first? If you did, some other error occurred during database access of the DiaObject table.
            		 
            ERROR 2022-06-19T01:07:07.440-05:00 lsst.ctrl.mpexec.mpGraphExecutor ()(mpGraphExecutor.py:500) - Task <TaskDef(lsst.ap.association.diaPipe.DiaPipelineTask, label=diaPipe) dataId={instrument: 'HSC', detector: 50, visit: 1218, ...}> failed; processing will continue for remaining tasks.
            		 
            Traceback (most recent call last):
            		 
              File "/software/lsstsw/stack_20220525/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1819, in _execute_context
            		 
                self.dialect.do_execute(
            		 
              File "/software/lsstsw/stack_20220525/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.10/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute
            		 
                cursor.execute(statement, parameters)
            		 
            psycopg2.errors.UndefinedColumn: column DiaObject.nearbyExtObj1 does not exist
            		 
            LINE 1: ...t"."nearbyObj3Dist", "DiaObject"."nearbyObj3LnP", "DiaObject...
            		 
                                                                         ^
            		 
            HINT:  Perhaps you meant to reference the column "DiaObject.nearbyObj1".

            I did run make_apdb.py in the usual way.

            Show
            kherner Kenneth Herner added a comment - As mentioned earlier today, everything seems to be running well except for the diaPipe step. The error I'm getting is of the form   ERROR 2022-06-19T01:07:07.411-05:00 lsst.ctrl.mpexec.singleQuantumExecutor (diaPipe:{instrument: 'HSC', detector: 50, visit: 1218, ...})(singleQuantumExecutor.py:220) - Execution of task 'diaPipe' on quantum {instrument: 'HSC', detector: 50, visit: 1218, ...} failed. Exception RuntimeError: Database query failed to load DiaObjects; did you call make_apdb.py first? If you did, some other error occurred during database access of the DiaObject table. ERROR 2022-06-19T01:07:07.440-05:00 lsst.ctrl.mpexec.mpGraphExecutor ()(mpGraphExecutor.py:500) - Task <TaskDef(lsst.ap.association.diaPipe.DiaPipelineTask, label=diaPipe) dataId={instrument: 'HSC', detector: 50, visit: 1218, ...}> failed; processing will continue for remaining tasks. Traceback (most recent call last):   File "/software/lsstsw/stack_20220525/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.10/site-packages/sqlalchemy/engine/base.py", line 1819, in _execute_context     self.dialect.do_execute(   File "/software/lsstsw/stack_20220525/conda/miniconda3-py38_4.9.2/envs/lsst-scipipe/lib/python3.10/site-packages/sqlalchemy/engine/default.py", line 732, in do_execute     cursor.execute(statement, parameters) psycopg2.errors.UndefinedColumn: column DiaObject.nearbyExtObj1 does not exist LINE 1: ...t"."nearbyObj3Dist", "DiaObject"."nearbyObj3LnP", "DiaObject...                                                              ^ HINT:  Perhaps you meant to reference the column "DiaObject.nearbyObj1". I did run make_apdb.py in the usual way.
            Hide
            Permalink
            kherner Kenneth Herner added a comment -

            Just a notebook review.

            Show
            kherner Kenneth Herner added a comment - Just a notebook review.
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            This looks good, though I do have one request that I would like to see included before we mark this as Done. I would really like to see an analysis of the DiaSources, good DiaSources, and DiaObjects between the different runs, but restricted to a good region well inside the patch boundaries. For example, restricted to the RA range from 150.2 to 150.3 and the Dec range from 2.15 to 2.3 where there are no edges or bright stars.

            Show
            sullivan Ian Sullivan added a comment - This looks good, though I do have one request that I would like to see included before we mark this as Done. I would really like to see an analysis of the DiaSources, good DiaSources, and DiaObjects between the different runs, but restricted to a good region well inside the patch boundaries. For example, restricted to the RA range from 150.2 to 150.3 and the Dec range from 2.15 to 2.3 where there are no edges or bright stars.
            Hide
            Permalink
            kherner Kenneth Herner added a comment - - edited

            Comments addressed in a recent merge commit.

            Show
            kherner Kenneth Herner added a comment - - edited Comments addressed in a recent merge commit.

              People

              Assignee:
              kherner Kenneth Herner
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Ian Sullivan
              Watchers:
              Ian Sullivan, John Parejko, Kenneth Herner
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.