Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-33960

Add astrometry residuals with refcat plots to analysis_drp

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      12
    • Epic Link:
    • Sprint:
      DRP S22B, DRP Plotting Sprint Mar 2022
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      This ticket aims to replicate the gen2 plots in the attached screenshot, in which the residuals between the source/object tables and the reference catalog are plotted. In order to do this, a matching task needs to also be added. Examples of the resulting figures are also attached.

        Attachments

          Issue Links

            Activity

            Show
            csaunder Clare Saunders added a comment - Successful Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36103/pipeline
            Hide
            yusra Yusra AlSayyad added a comment -

            OK, There was some problems with the Task conventions which I'm sure you just copied and pasted from other tasks in analysis_drp.

            The major problem is that it reads in the entire `objectTable_tract` matches it to the reference catalog and then writes out the entire thing with the refcatalog columns appended.

            Since we use reference catalogs for calibrating astrometry and photometry we are only ever going to want to read in directly comparable coord or psf/calib flux columns. How about for now, you just read in the columns that YOUR plots need. e.g.: ['coord_ra', 'coord_decl', 'iRa', 'iDecl', 'iRaErr' 'iDeclErr'] and others can add as needed. What would be really cool is if it could KNOW which columns are needed from the downstream plotting tasks that use it. I bet that's possible somehow! paging Nate Lust to put it on his radar in the future...

            Show
            yusra Yusra AlSayyad added a comment - OK, There was some problems with the Task conventions which I'm sure you just copied and pasted from other tasks in analysis_drp. The major problem is that it reads in the entire `objectTable_tract` matches it to the reference catalog and then writes out the entire thing with the refcatalog columns appended. Since we use reference catalogs for calibrating astrometry and photometry we are only ever going to want to read in directly comparable coord or psf/calib flux columns. How about for now, you just read in the columns that YOUR plots need. e.g.: ['coord_ra', 'coord_decl', 'iRa', 'iDecl', 'iRaErr' 'iDeclErr'] and others can add as needed. What would be really cool is if it could KNOW which columns are needed from the downstream plotting tasks that use it. I bet that's possible somehow! paging Nate Lust to put it on his radar in the future...
            Hide
            csaunder Clare Saunders added a comment -

            Ok, that sounds workable. A bit more is required, since we at least need the columns that are commonly used in the dataSelectors functions, but that is still a lot fewer than ALL columns.

            Show
            csaunder Clare Saunders added a comment - Ok, that sounds workable. A bit more is required, since we at least need the columns that are commonly used in the dataSelectors functions, but that is still a lot fewer than ALL columns.
            Hide
            yusra Yusra AlSayyad added a comment -

            This is mergeable but needs a clean up ticket. I'll do another review round with the intention of making a todo-list for that ticket

            Show
            yusra Yusra AlSayyad added a comment - This is mergeable but needs a clean up ticket. I'll do another review round with the intention of making a todo-list for that ticket
            Hide
            csaunder Clare Saunders added a comment -

            Ok, looking at this again in the light of day I would change how I grabbed the columns to use, but some guidance for other stuff would be helpful.

            Show
            csaunder Clare Saunders added a comment - Ok, looking at this again in the light of day I would change how I grabbed the columns to use, but some guidance for other stuff would be helpful.
            Show
            csaunder Clare Saunders added a comment - New Jenkins run with ci_imsim and ci_hsc: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36472/pipeline/

              People

              Assignee:
              csaunder Clare Saunders
              Reporter:
              csaunder Clare Saunders
              Reviewers:
              Yusra AlSayyad
              Watchers:
              Clare Saunders, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.