# Add PSF size residual plots in analysis_drp

XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
2
• Sprint:
DRP Plotting Sprint Mar 2022
• Team:
Data Release Production
• Urgent?:
No

#### Description

Add fractional PSF size residual plots (1-star_size/PSF_size) to be produced automatically during regular RC2/DC2 reprocessing.

#### Activity

Hide

Butler: /repo/main

The plot below corresponds to visit=352 . Labelling issues will be fixed in DM-33971

Show
Arun Kannawadi added a comment - Butler: /repo/main Collection: u/kannawad/plotSprint2022 The plot below corresponds to visit=352 . Labelling issues will be fixed in DM-33971
Hide

The selection looks like it is allowing a bunch of junk objects beyond mag > 23.5 with fraction size differences being scattered throughout. Unless it is a quick fix by changing the selectors, that is out of scope for this ticket.

Show
Arun Kannawadi added a comment - The selection looks like it is allowing a bunch of junk objects beyond mag > 23.5 with fraction size differences being scattered throughout. Unless it is a quick fix by changing the selectors, that is out of scope for this ticket.
Hide
Lee Kelvin added a comment - - edited

Thanks Arun, this is a nice plot addition. I realize that there are a number of small aesthetic issues here, such as the low DPI of the image, overlapping plot labels, and incorrect plot labels. I understand that Sophie will address most of these in DM-31751, with Arun addressing the remaining plot label issues in DM-33971.

I added a few minor comments on GH which I hope are helpful. I also attach a version of the plot produced using this ticket for visit 1228 with this command:

 pipetask --long-log run --register-dataset-types \ -b /repo/main \ -i HSC/runs/RC2/w_2022_08/DM-33741 \ --output-run u/lskelvin/scratch/DM-33966 \ -p $ANALYSIS_DRP_DIR/pipelines/visitQAEllipPlots.yaml#plot_shapeSizeResidsDiff_scatter_visit \ -d "instrument='HSC' AND skymap='hsc_rings_v1' AND visit=1228"  Not sure if Jenkins needs to run here or not (will ask in our daily stand up shortly), but otherwise, this looks good to merge to me! Edit: It looks like it is possible to run Jenkins here, and so, assuming Jenkins doesn't complain, this looks good to merge to me! Show Lee Kelvin added a comment - - edited Thanks Arun, this is a nice plot addition. I realize that there are a number of small aesthetic issues here, such as the low DPI of the image, overlapping plot labels, and incorrect plot labels. I understand that Sophie will address most of these in DM-31751 , with Arun addressing the remaining plot label issues in DM-33971 . I added a few minor comments on GH which I hope are helpful. I also attach a version of the plot produced using this ticket for visit 1228 with this command: pipetask --long-log run --register-dataset-types \ -b /repo/main \ -i HSC/runs/RC2/w_2022_08/DM-33741 \ --output-run u/lskelvin/scratch/DM-33966 \ -p$ANALYSIS_DRP_DIR/pipelines/visitQAEllipPlots.yaml#plot_shapeSizeResidsDiff_scatter_visit \ -d "instrument='HSC' AND skymap='hsc_rings_v1' AND visit=1228" Not sure if Jenkins needs to run here or not (will ask in our daily stand up shortly), but otherwise, this looks good to merge to me! Edit: It looks like it is possible to run Jenkins here, and so, assuming Jenkins doesn't complain, this looks good to merge to me!
Hide

Thanks, Lee. Incorporated most of the comments and clarified the remaining on Github.

Show
Arun Kannawadi added a comment - Thanks, Lee. Incorporated most of the comments and clarified the remaining on Github. Pre-review comments Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36070/pipeline Post-review comments Jenkins run:  https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36073/pipeline/

#### People

Assignee:
Reporter:
Reviewers:
Lee Kelvin
Watchers: