Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3401

Explicitly disallow alias cycles in Schemas

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      The current guard against cycles is lazy and incomplete, as it seemed unlikely we'd ever have them. That's already been disproven (DM-3400), so it seems prudent to fix the guard code now.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Removing this from the current sprint and increasing the story points, as it's a lot trickier to fix than I'd thought; I think the simplest approach is to make alias expansion nonrecursive and rewrite some of the backwards-compatibility read code from DM-1766, but a re-think of how partial alias matches work might also be worthwhile, especially if we tackle DM-1764 first.

            Show
            jbosch Jim Bosch added a comment - Removing this from the current sprint and increasing the story points, as it's a lot trickier to fix than I'd thought; I think the simplest approach is to make alias expansion nonrecursive and rewrite some of the backwards-compatibility read code from DM-1766 , but a re-think of how partial alias matches work might also be worthwhile, especially if we tackle DM-1764 first.
            Hide
            smonkewitz Serge Monkewitz added a comment -

            Another thing we might want to consider changing: in the current afw code, it seems legal for an alias to shadow a field name. This should probably be an error, meaning that the table library should disallow adding a shadowed a field to a schema, or an alias that causes a field to be shadowed to an alias map. One potentially negative consequence is that implementing this may involve coupling alias maps and schemas more tightly together.

            Show
            smonkewitz Serge Monkewitz added a comment - Another thing we might want to consider changing: in the current afw code, it seems legal for an alias to shadow a field name. This should probably be an error, meaning that the table library should disallow adding a shadowed a field to a schema, or an alias that causes a field to be shadowed to an alias map. One potentially negative consequence is that implementing this may involve coupling alias maps and schemas more tightly together.
            Hide
            lguy Leanne Guy added a comment -

            Reviewed at dm-ccb, still a valid issue but not a high priority

            Show
            lguy Leanne Guy added a comment - Reviewed at dm-ccb, still a valid issue but not a high priority

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Watchers:
              Jim Bosch, Leanne Guy, Serge Monkewitz
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins Builds

                  No builds found.