Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34012

Rotator software limits overwrite

    XMLWordPrintable

    Details

      Description

      Investigate the overwrite for the software limit switch for the rotator.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          hdrass Holger Drass created issue -
          hdrass Holger Drass made changes -
          Field Original Value New Value
          Link This issue blocks FRACAS-90 [ FRACAS-90 ]
          ttsai Te-Wei Tsai made changes -
          Component/s ts_main_telescope [ 16710 ]
          Epic Link DM-27620 [ 441884 ]
          Issue Type Bug [ 1 ] Story [ 10001 ]
          ttsai Te-Wei Tsai made changes -
          Sprint TSSW Sprint - Mar 14 - Mar 28 [ 1154 ]
          ttsai Te-Wei Tsai made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          ttsai Te-Wei Tsai made changes -
          Story Points 0
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment - - edited

          The configuration file of rotator controller can overwrite the software limits: default.yaml. This only happens when using the CSC to put the rotator to the Disabled state: https://github.com/lsst-ts/ts_rotator_controller/blob/develop/src/commanding.c#L461-L472

          Show
          ttsai Te-Wei Tsai added a comment - - edited The configuration file of rotator controller can overwrite the software limits:  default.yaml . This only happens when using the CSC to put the rotator to the Disabled state: https://github.com/lsst-ts/ts_rotator_controller/blob/develop/src/commanding.c#L461-L472
          ttsai Te-Wei Tsai made changes -
          Attachment block_limit_check_bias_calc.png [ 58053 ]
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment - - edited

          The block of limit check bias calc will compare the rotator's position with the upper/lower limits to decide the flag of positionFeedbackFault. If there is fault, it will trigger the ControlledStopping state to stop the rotator's movement. This has the potential to overshoot the rotator's position to be out of range of limits.

          Show
          ttsai Te-Wei Tsai added a comment - - edited The block of limit check bias calc will compare the rotator's position with the upper/lower limits to decide the flag of positionFeedbackFault . If there is fault, it will trigger the ControlledStopping state to stop the rotator's movement. This has the potential to overshoot the rotator's position to be out of range of limits.
          Hide
          Permalink
          ttsai Te-Wei Tsai added a comment -

          Investigate the Simulink model as requested.

          Show
          ttsai Te-Wei Tsai added a comment - Investigate the Simulink model as requested.
          ttsai Te-Wei Tsai made changes -
          Reviewers Holger Drass [ hdrass ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          Permalink
          hdrass Holger Drass added a comment -

          Thanks, Te-Wei! This is very valuable information.

          Show
          hdrass Holger Drass added a comment - Thanks, Te-Wei! This is very valuable information.
          hdrass Holger Drass made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          ttsai Te-Wei Tsai made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            ttsai Te-Wei Tsai
            Reporter:
            hdrass Holger Drass
            Reviewers:
            Holger Drass
            Watchers:
            Holger Drass, Te-Wei Tsai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.