Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-3406

Consolidate display code in astrometry

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw, meas_astrom
    • Labels:
      None
    • Team:
      Alert Production

      Description

      Prompted by DM-3209:

      The ANetAstrometryTask uses 3 different means for debugging displays:

      • lsst.pipe.base.Task.display, which is an old old mechanism for displaying debugging info (I think it was in Pipette before we converted that to pipe_base + pipe_tasks). It's not used much (either in code or activated), and its capability is pretty much superseded by what's in lsst.meas.astrom.display, except that it integrates the use of lsstDebug.
      • lsst.meas.astrom.anetAstrometry.showAstrometry, which appears to be intended for use in WCS fitting loops, since it calculates fit statistics.
      • lsst.meas.astrom.display.displayAstrometry, which is the most complete display code, though it's clearly lacking some features (e.g., fit statistics provided by showAstrometry, integration with lsstDebug or some other facility for activation).

      It might be helpful to consolidate these. The existence of multiple ways to do things likely indicates that we haven't yet found the best way. I suggest that we need some basic functions to display source catalogs and match lists in afw (more basic than displayAstrometry but building on the display code in afw because I don't want to have to write multiple lines to display a source catalog). Astrometry is likely a useful area to consider when designing display tools for debugging.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            lsst.pipe.base.task.Task.display is gone as of DM-4428.

            Show
            swinbank John Swinbank added a comment - lsst.pipe.base.task.Task.display is gone as of DM-4428 .
            Hide
            swinbank John Swinbank added a comment -

            ANetAstrometryTask is obsolete. I've not checked other astrometry tasks, but I can't imagine that we'll schedule effort just to clean up display code except as part of some other work. Won't fixing this for now.

            Show
            swinbank John Swinbank added a comment - ANetAstrometryTask is obsolete. I've not checked other astrometry tasks, but I can't imagine that we'll schedule effort just to clean up display code except as part of some other work. Won't fixing this for now.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              price Paul Price
              Watchers:
              John Parejko, John Swinbank, Paul Price, Robert Lupton, Russell Owen, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.