Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34150

Should logger be a mandatory parameter or a package log

    XMLWordPrintable

Details

    • Story
    • Status: To Do
    • Resolution: Unresolved
    • None
    • faro
    • None

    Description

      See comments on this PR

      There is a bit of a philosophical logging issue in this entire file. It's probably not something for you to solve but given that almost all of these logger messages (in this file) are at DEBUG level should the caller be in charge of whether log output is possible at all or should the person running the task code? I think I'd prefer it if a log message was always issued if I asked for DEBUG output so the philosophical question then becomes whether the logger should be a mandatory parameter (the logger is the same as the task code) or a package log (lsst.utils.logging.getLogger(name)) which is always set to a predictable value in this file and is then an lsst.faro logger explicitly. We could use that logger if the caller doesn't set one but then you have a problem with unpredictability of the logger name. I don't think this is something that should be sorted out on this ticket but I think @jeffcarlin and @bechtol should think about it.

      Attachments

        Activity

          There are no comments yet on this issue.

          People

            Unassigned Unassigned
            kbechtol Keith Bechtol
            Jeffrey Carlin, Keith Bechtol
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:

              Jenkins

                No builds found.