Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34169

Pin responses version in 0.8.0 env

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      The new version of responses breaks the daf_butler S3 tests for the v23 release branches in the 0.8.0 env (because moto is pinned for the other tests). Fabio Hernandez has determined that we need to add a pin to the conda environment of responses <= 0.18.0 for a successful build.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33769 Improve timeout, retry and connexion persistence of webDAV client

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-33769 [ DM-33769 ]
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            I guess we're not expecting any more patches of 0.18, so 0.18.0 is OK.

            Also note that we don't use responses directly, so it hasn't been explicitly in the environment previously.

            There's no chance to unpin moto, correct?

            Show
            ktl Kian-Tat Lim added a comment - I guess we're not expecting any more patches of 0.18, so 0.18.0 is OK. Also note that we don't use responses directly, so it hasn't been explicitly in the environment previously. There's no chance to unpin moto, correct?
            ktl Kian-Tat Lim made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I can't remember why we didn't want to backport the moto fix to 23.x. Were we worried that there would be other breakages coming and it was safer to stick to a version for 23 that we knew was okay?

            Show
            tjenness Tim Jenness added a comment - I can't remember why we didn't want to backport the moto fix to 23.x. Were we worried that there would be other breakages coming and it was safer to stick to a version for 23 that we knew was okay?
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            And also the v23.0 release could still use the new 0.8.0 rubin-env.

            Show
            tjenness Tim Jenness added a comment - And also the v23.0 release could still use the new 0.8.0 rubin-env.
            Hide
            Permalink
            ktl Kian-Tat Lim added a comment -

            I merged this as a build bump, but I'm a little worried that Jenkins workspaces won't update.  We may be better off making it a patch version bump.

            Show
            ktl Kian-Tat Lim added a comment - I merged this as a build bump, but I'm a little worried that Jenkins workspaces won't update.  We may be better off making it a patch version bump.
            ktl Kian-Tat Lim made changes -
            Resolution Done [ 10000 ]
            Status In Progress [ 3 ] Done [ 10002 ]

              People

              Assignee:
              ktl Kian-Tat Lim
              Reporter:
              tjenness Tim Jenness
              Watchers:
              Fabio Hernandez, Kian-Tat Lim, Tim Jenness, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.