Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34175

Simplify ingest with extended exposure table and related dimensions

    XMLWordPrintable

    Details

    • Team:
      External
    • Urgent?:
      No

      Description

      For PFS cameras, the slit head is the only light source, so we only ever get lines up and down the detectors. In order to build flats, we dither the slit head side to side. My flat creation task therefore needs to know about the slit position (I coadd images taken with the same slit position in order to remove cosmic rays, normalise out the fiber profile, and then sum the normalised images from different slit positions). I figure I can create a dimension that will let me do that grouping, but I need to get the slit position into the registry. I propose changes to the RawIngestTask and ObservationInfo that will allow me to subclass and extend their behaviours in order to accomplish this.

        Attachments

          Activity

          No builds found.
          price Paul Price created issue -
          Hide
          price Paul Price added a comment -

          Created PRs, but I've apparently a few things to do (fix lint errors, run Jenkins) before submitting for review in earnest.

          Show
          price Paul Price added a comment - Created PRs, but I've apparently a few things to do (fix lint errors, run Jenkins) before submitting for review in earnest.
          Show
          price Paul Price added a comment - Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36235/pipeline/
          price Paul Price made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          price Paul Price added a comment -

          This works for me. Please have a look and let me know what you think.

          Show
          price Paul Price added a comment - This works for me. Please have a look and let me know what you think.
          price Paul Price made changes -
          Reviewers Jim Bosch, Tim Jenness [ jbosch, tjenness ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          price Paul Price added a comment -

          I believe I've addressed everyone's comments on the GitHub PRs. Please let me know if I'm missing anything, or if you have any further concerns. I'm aiming to merge later today.

          Show
          price Paul Price added a comment - I believe I've addressed everyone's comments on the GitHub PRs. Please let me know if I'm missing anything, or if you have any further concerns. I'm aiming to merge later today.
          Show
          price Paul Price added a comment - Final Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36264/pipeline/
          tjenness Tim Jenness made changes -
          Reviewers Jim Bosch, Tim Jenness [ jbosch, tjenness ] Jim Bosch [ jbosch ]
          Hide
          tjenness Tim Jenness added a comment -

          The astro_metadata_translator stuff seems like a reasonable compromise. One big test will be seeing whether ingest-raws still works properly with index files (so run astrometadata write-sidecar and check that your special fiber position gets inserted properly).

          I'll remove my name from the reviewer list.

          Show
          tjenness Tim Jenness added a comment - The astro_metadata_translator stuff seems like a reasonable compromise. One big test will be seeing whether ingest-raws still works properly with index files (so run astrometadata write-sidecar and check that your special fiber position gets inserted properly). I'll remove my name from the reviewer list.
          jbosch Jim Bosch made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          price Paul Price added a comment -

          Thank you, both. This has merged to main.

          Show
          price Paul Price added a comment - Thank you, both. This has merged to main .
          price Paul Price made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            price Paul Price
            Reporter:
            price Paul Price
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Paul Price, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.