Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34200

Update getTemplate connections

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      AP S22-4 (March), AP S22-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      DM-33745 updated the Task to create templates for image differencing. This involved removing ImageDifferenceTask config settings for getTemplate.coaddName, but should have added connections.coaddName for the getTemplateTask config to maintain the same settings for our testdata repos.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34237 Remove ap_verify dataset Gen 2 config files

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33745 Refactor Task to make ImageDifference template

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            PRs:

            https://github.com/lsst/ap_pipe/pull/101

            https://github.com/lsst/ap_verify_ci_cosmos_pdr2/pull/23

            https://github.com/lsst/ap_verify_ci_hits2015/pull/35

            https://github.com/lsst/ap_verify_hits2015/pull/40

            https://github.com/lsst/ap_verify/pull/155

            Show
            sullivan Ian Sullivan added a comment - PRs: https://github.com/lsst/ap_pipe/pull/101 https://github.com/lsst/ap_verify_ci_cosmos_pdr2/pull/23 https://github.com/lsst/ap_verify_ci_hits2015/pull/35 https://github.com/lsst/ap_verify_hits2015/pull/40 https://github.com/lsst/ap_verify/pull/155
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Note: I have merged these PRs since I believe the AP CI runs tonight would otherwise be broken.

            Show
            sullivan Ian Sullivan added a comment - Note: I have merged these PRs since I believe the AP CI runs tonight would otherwise be broken.
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Could you please take a look at these PRs? This is a little unusual since I already merged all of the PRs, but that was because I believed main was broken after my merge of DM-33745, and I wanted to get a quick fix in so that our CI builds would not be broken on the weekend.

            Show
            sullivan Ian Sullivan added a comment - Could you please take a look at these PRs? This is a little unusual since I already merged all of the PRs, but that was because I believed main was broken after my merge of DM-33745 , and I wanted to get a quick fix in so that our CI builds would not be broken on the weekend.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Unfortunately, this merge did introduce one bug in ApVerifyWithFakes:apPipeWithFakes. I don't think anybody's actually using this subset, so the fix isn't urgent.

            Show
            krzys Krzysztof Findeisen added a comment - Unfortunately, this merge did introduce one bug in ApVerifyWithFakes:apPipeWithFakes . I don't think anybody's actually using this subset, so the fix isn't urgent.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            I suggest doing the apPipeWithFakes fix on DM-34237.

            Show
            krzys Krzysztof Findeisen added a comment - I suggest doing the apPipeWithFakes fix on DM-34237 .
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            That sounds great, thank you Krzysztof Findeisen.

            Show
            sullivan Ian Sullivan added a comment - That sounds great, thank you Krzysztof Findeisen .

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Ian Sullivan, Krzysztof Findeisen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.