Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34217

Move ScaleVarianceTask

    XMLWordPrintable

    Details

      Description

      ScaleVarianceTask is used in image differencing, and the refactored ImageDifferenceTask (DM-33001) will soon be in ip_diffim instead of pipe_tasks. The current ScaleVarianceTask lives in pipe_tasks, so it would create a circular dependency to import it in ip_diffim. Instead, it should be moved to meas_algorithms, where it would fit in with similar measurement algorithms like SubtractBackgroundTask.

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-843 Move ScaleVarianceTask to meas_algorithms

          • Implemented
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33001 Design refactoring of ImageDifferenceTask

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            PRs:

            https://github.com/lsst/meas_algorithms/pull/276

            https://github.com/lsst/pipe_tasks/pull/656

            Show
            sullivan Ian Sullivan added a comment - PRs: https://github.com/lsst/meas_algorithms/pull/276 https://github.com/lsst/pipe_tasks/pull/656
            Hide
            Permalink
            sullivan Ian Sullivan added a comment -

            Eli Rykoff, would you be willing to review this ticket? It is a (hopefully) striaghtforward move of ScaleVarianceTask from pipe_tasks to meas_algorithms, so that it can be used in ip_diffim.

            Show
            sullivan Ian Sullivan added a comment - Eli Rykoff , would you be willing to review this ticket? It is a (hopefully) striaghtforward move of ScaleVarianceTask from pipe_tasks to meas_algorithms, so that it can be used in ip_diffim.
            Hide
            Permalink
            erykoff Eli Rykoff added a comment -

            See comment on the PR about properly deprecating the usage of this task from pipe_tasks. Otherwise looks good (and straightforward).

            Show
            erykoff Eli Rykoff added a comment - See comment on the PR about properly deprecating the usage of this task from pipe_tasks. Otherwise looks good (and straightforward).

              People

              Assignee:
              sullivan Ian Sullivan
              Reporter:
              sullivan Ian Sullivan
              Reviewers:
              Eli Rykoff
              Watchers:
              Eli Rykoff, Ian Sullivan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.