Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34242

ci_hsc_gen2 test is broken by pipe_tasks changes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Story Points:
      0.4
    • Epic Link:
    • Sprint:
      DB_S22_12
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      Today's merge of DM-33857 resulted in failing ci_hsc_gen2 tests:

      root FATAL: meas_extensions_psfex in packages: FAIL
      		 
      Traceback (most recent call last):
      		 
        File "/Users/square/j/ws/stack-os-matrix/macos/lsstsw/build/ci_hsc_gen2/bin/validate.py", line 3, in <module>
      		 
          main()
      		 
        File "/Users/square/j/ws/stack-os-matrix/macos/lsstsw/build/ci_hsc_gen2/python/lsst/ci/hsc/gen2/validate.py", line 101, in main
      		 
          validator.run({})
      		 
        File "/Users/square/j/ws/stack-os-matrix/macos/lsstsw/build/ci_hsc_gen2/python/lsst/ci/hsc/gen2/validate.py", line 501, in run
      		 
          self.assertTrue(pkg + " in packages", pkg in packages)
      		 
        File "/Users/square/j/ws/stack-os-matrix/macos/lsstsw/build/ci_hsc_gen2/python/lsst/ci/hsc/gen2/validate.py", line 138, in assertTrue
      		 
          raise AssertionError("Failed test: %s" % description)
      		 
      AssertionError: Failed test: meas_extensions_psfex in packages

      validate.py probably need updates.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33857 Make Piff the default PsfDeterminer in DRP.yaml

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            kannawad Arun Kannawadi added a comment -

            As a gen3 only package, the ticket making piff the default wouldn't have been checked against this. I believe this is coming from the fact that setup required(meas_extensions_psfex) was removed from UPS tables and this package is checking for that, which wouldn't be setup.

            Show
            kannawad Arun Kannawadi added a comment - As a gen3 only package, the ticket making piff the default wouldn't have been checked against this. I believe this is coming from the fact that setup required(meas_extensions_psfex) was removed from UPS tables and this package is checking for that, which wouldn't be setup.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment - - edited

            Kian-Tat Lim, should be quick review. It has built successfully locally, and Jenkins is running, will wait until it's done before merge.

            Show
            salnikov Andy Salnikov added a comment - - edited Kian-Tat Lim , should be quick review. It has built successfully locally, and Jenkins is running, will wait until it's done before merge.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Arun Kannawadi, indeed this was triggered by changes to the table file in pipe_tasks. Package list is stored in Butler for gen2 as well, and that list is checked against a hardcoded list of packages in ci_hsc_gen2. Hopefully gen2 will disappear soon and we won't have this problem again.

            Show
            salnikov Andy Salnikov added a comment - Arun Kannawadi , indeed this was triggered by changes to the table file in pipe_tasks. Package list is stored in Butler for gen2 as well, and that list is checked against a hardcoded list of packages in ci_hsc_gen2. Hopefully gen2 will disappear soon and we won't have this problem again.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            As Arun has already reviewed the PR, and Jenkins finally finished the build, I'm going to click "Reviewed" and merge it.

            Show
            salnikov Andy Salnikov added a comment - As Arun has already reviewed the PR, and Jenkins finally finished the build, I'm going to click "Reviewed" and merge it.

              People

              Assignee:
              salnikov Andy Salnikov
              Reporter:
              salnikov Andy Salnikov
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Andy Salnikov, Arun Kannawadi, Joshua Meyers, Kian-Tat Lim
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.