Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34254

ap_verify metrics report 0 completeness after switch to Piff

    XMLWordPrintable

    Details

      Description

      The fakes completeness metrics have dropped to zero in all ap_verify runs after DM-33857, for both ap_verify_ci_cosmos_pdr2 and ap_verify_ci_hits2015. Given that we are still detecting sources (though fewer), this may be the result of the completeness metrics making assumptions about catalog schemas and contents that are no longer true.

      Investigate and restore the metrics.

        Attachments

          Issue Links

          has to be done before

          Bug - A problem which impairs or prevents the functions of the product. DM-34699 Patch the ap_pipe config reset hack

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-32694 Split AP pipeline into ApPipeWithFakes

          • Done
          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34531 Cleanup piff PSF determiner model size config options

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34531 Cleanup piff PSF determiner model size config options

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34586 Use --fail-fast in ap_verify to halt execution on first error

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-34698 Default piff kernelSize to 25

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-33857 Make Piff the default PsfDeterminer in DRP.yaml

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            16 older comments
            Hide
            Permalink
            yusra Yusra AlSayyad added a comment -

            Ideally the change would be global in meas_extensions_piff. 

            Show
            yusra Yusra AlSayyad added a comment - Ideally the change would be global in meas_extensions_piff. 
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Changing this globally in meas_extensions_piff would affect DRP, which would require DRP to do validation runs. We'd rather get the change in sooner than that, I think. We can have a follow-up ticket to make the change in meas_extensions_piff.

            Show
            Parejkoj John Parejko added a comment - Changing this globally in meas_extensions_piff would affect DRP, which would require DRP to do validation runs. We'd rather get the change in sooner than that, I think. We can have a follow-up ticket to make the change in meas_extensions_piff.
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Thanks, John Parejko. DRP is going to handle changing the Piff default to 25. In the meantime we should set it for all ap pipelines. Right now you have a PR only for the HSC CI dataset; we should make the config change in ap_pipe instead, and confirm that it is inherited appropriately in CI.

            I left some other questions on the pipe_tasks and meas_extensions_piff PRs.

            Show
            ebellm Eric Bellm added a comment - Thanks, John Parejko . DRP is going to handle changing the Piff default to 25. In the meantime we should set it for all ap pipelines. Right now you have a PR only for the HSC CI dataset; we should make the config change in ap_pipe instead, and confirm that it is inherited appropriately in CI. I left some other questions on the pipe_tasks and meas_extensions_piff PRs.
            Hide
            Permalink
            Parejkoj John Parejko added a comment - - edited

            New Jenkins, with change in ap_pipe:https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36549/pipeline

            Show
            Parejkoj John Parejko added a comment - - edited New Jenkins, with change in ap_pipe: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36549/pipeline
            Hide
            Permalink
            ebellm Eric Bellm added a comment -

            Looks good once Jenkins is available.

            Show
            ebellm Eric Bellm added a comment - Looks good once Jenkins is available.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Eric Bellm
              Watchers:
              Eric Bellm, Ian Sullivan, John Parejko, Joshua Meyers, Krzysztof Findeisen, Lee Kelvin, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.