Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34326

Make Configurable actions add their targets to import list

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_tasks
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      ConfigurableAction(struct)Field should add their targets to import list when serializing to ensure the variables are in scope.

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            This turned out not to be an issue with ConfigurableAction (fields), but in a pex_config ConfigDictField who's owned config itself had a ConfigurableActionStructField in it. ConfigDictFields were not collecting the imports for the configs they owned. This has been fixed, and a test added.

            Show
            nlust Nate Lust added a comment - This turned out not to be an issue with ConfigurableAction (fields), but in a pex_config ConfigDictField who's owned config itself had a ConfigurableActionStructField in it. ConfigDictFields were not collecting the imports for the configs they owned. This has been fixed, and a test added.
            Hide
            jbosch Jim Bosch added a comment -

            For posterity, since at first I was not totally convinced that ConfigDictField should be responsible for saving its imports; this support was not there originally because the config classes held by ConfigDictField are fixed, not dynamic, and hence I thought maybe this was a new issue created by ConfigurableAction that should be fixed in ConfigurableAction somehow. But I'm pretty sure that's not the case: the same issue would also have arisen if we had ever put a Config class that had a nested dynamic field (like RegistryField or ConfigurableField) in ConfigDictField.

            Show
            jbosch Jim Bosch added a comment - For posterity, since at first I was not totally convinced that ConfigDictField should be responsible for saving its imports; this support was not there originally because the config classes held by ConfigDictField are fixed, not dynamic, and hence I thought maybe this was a new issue created by ConfigurableAction that should be fixed in ConfigurableAction somehow. But I'm pretty sure that's not the case: the same issue would also have arisen if we had ever put a Config class that had a nested dynamic field (like RegistryField or ConfigurableField ) in ConfigDictField .

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              nlust Nate Lust
              Reviewers:
              Jim Bosch
              Watchers:
              Jim Bosch, Nate Lust
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.