Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34384

Make CSC.start more deterministic and easer to use

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      TSSW Sprint - Apr 11 - Apr 25
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.

      Fix this by breaking start into two pieces: start and start_phase2. Move the handling of initial state to phase2.

      Also improve SalLogHandler so messages can be logged from background threads.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          rowen Russell Owen created issue -
          rowen Russell Owen made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          rowen Russell Owen made changes -
          Description There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.

          Fix this by breaking start into two pieces: {{start}} and {{start_phase2}}. Move the handling of initial state to phase2.           		There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.

          Fix this by breaking start into two pieces: {{start}} and {{start_phase2}}. Move the handling of initial state to phase2.

          Also improve SalLogHandler so messages can be logged from background threads.
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Pull request: https://github.com/lsst-ts/ts_salobj/pull/233

          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_salobj/pull/233
          rowen Russell Owen made changes -
          Reviewers Wouter van Reeven [ wvreeven ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          Permalink
          wvreeven Wouter van Reeven added a comment -

          Reviewed on GitHub. Please have a look at why the build failed and fix.

          Show
          wvreeven Wouter van Reeven added a comment - Reviewed on GitHub. Please have a look at why the build failed and fix.
          wvreeven Wouter van Reeven made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          rowen Russell Owen added a comment -

          Merged to develop. I'll postpone release until I know if it's to be included in cycle 25

          Show
          rowen Russell Owen added a comment - Merged to develop. I'll postpone release until I know if it's to be included in cycle 25
          rowen Russell Owen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]

            People

            Assignee:
            rowen Russell Owen
            Reporter:
            rowen Russell Owen
            Reviewers:
            Wouter van Reeven
            Watchers:
            Russell Owen, Wouter van Reeven
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.