Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_middleware
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:TSSW Sprint - Apr 11 - Apr 25
-
Team:Telescope and Site
-
Urgent?:No
Description
There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.
Fix this by breaking start into two pieces: start and start_phase2. Move the handling of initial state to phase2.
Also improve SalLogHandler so messages can be logged from background threads.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Description |
There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.
Fix this by breaking start into two pieces: {{start}} and {{start_phase2}}. Move the handling of initial state to phase2. |
There is a sequencing issue in BaseCsc.start: it waits for the SalInfo to be started, then writes some topics and then transitions to the desired initial state. But it is common for subclasses to want to write topics before those state transitions occur.
Fix this by breaking start into two pieces: {{start}} and {{start_phase2}}. Move the handling of initial state to phase2. Also improve SalLogHandler so messages can be logged from background threads. |
| Reviewers | Wouter van Reeven [ wvreeven ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |