Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ci_hsc_gen3, pipe_tasks
-
Labels:
-
Story Points:3
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
The pipe_tasks tests in nopytest_test_coadds.py are not really unit tests, and are actually integration tests, and are well suited for ci_hsc_gen3. Furthermore, they rely on a complicated mock-up of the gen2 task interface which is being removed.
This will also greatly simplify the tests in pipe_tasks because these tests are slow and take a lot of disk space.
Attachments
Issue Links
- is triggering
-
- Done
Activity
You've probably already seen it, but note section 3.2 of the gen2 removal doc, which is about this test:
https://confluence.lsstcorp.org/display/DM/Gen2+Middleware+Removal+Planning
I had seen it ages ago, but it was not front of mind when I was doing this. Work on DM-21518 made me realize how to do this quickly and easily.
This look great...thanks so much for doing this! I think you have certainly met (and more likely exceeded) Jim Bosch's expectations outlined in the confluence page referenced by John Parejko for this migration. I've made some very minor comments on the PRs, but otherwise, given the green Jenkins, you're good to go!
SPs?
PRs:
https://github.com/lsst/ci_hsc_gen3/pull/70
https://github.com/lsst/pipe_tasks/pull/663
Jenkins:
https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36335/pipeline