Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-34390

Move integration tests from pipe_tasks nopytest_test_coadds to ci_hsc_gen3

    XMLWordPrintable

    Details

      Description

      The pipe_tasks tests in nopytest_test_coadds.py are not really unit tests, and are actually integration tests, and are well suited for ci_hsc_gen3. Furthermore, they rely on a complicated mock-up of the gen2 task interface which is being removed.

      This will also greatly simplify the tests in pipe_tasks because these tests are slow and take a lot of disk space.

        Attachments

          Issue Links

            Activity

            Show
            erykoff Eli Rykoff added a comment - PRs: https://github.com/lsst/ci_hsc_gen3/pull/70 https://github.com/lsst/pipe_tasks/pull/663 Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/36335/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            You've probably already seen it, but note section 3.2 of the gen2 removal doc, which is about this test:

            https://confluence.lsstcorp.org/display/DM/Gen2+Middleware+Removal+Planning

            Show
            Parejkoj John Parejko added a comment - You've probably already seen it, but note section 3.2 of the gen2 removal doc, which is about this test: https://confluence.lsstcorp.org/display/DM/Gen2+Middleware+Removal+Planning
            Hide
            erykoff Eli Rykoff added a comment -

            I had seen it ages ago, but it was not front of mind when I was doing this. Work on DM-21518 made me realize how to do this quickly and easily.

            Show
            erykoff Eli Rykoff added a comment - I had seen it ages ago, but it was not front of mind when I was doing this. Work on DM-21518 made me realize how to do this quickly and easily.
            Hide
            lauren Lauren MacArthur added a comment -

            This look great...thanks so much for doing this!  I think you have certainly met (and more likely exceeded) Jim Bosch's expectations outlined in the confluence page referenced by John Parejko for this migration.  I've made some very minor comments on the PRs, but otherwise, given the green Jenkins, you're good to go!

            Show
            lauren Lauren MacArthur added a comment - This look great...thanks so much for doing this!  I think you have certainly met (and more likely exceeded) Jim Bosch 's expectations outlined in the confluence page referenced by John Parejko  for this migration.  I've made some very minor comments on the PRs, but otherwise, given the green Jenkins, you're good to go!
            Hide
            yusra Yusra AlSayyad added a comment -

            SPs?

            Show
            yusra Yusra AlSayyad added a comment - SPs?

              People

              Assignee:
              erykoff Eli Rykoff
              Reporter:
              erykoff Eli Rykoff
              Reviewers:
              Lauren MacArthur
              Watchers:
              Eli Rykoff, Jim Bosch, John Parejko, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.